OG-906: OG-903: Enable the private RelayServer registration and operation #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion OG-903: Add 'blacklisted recipients' configuration field
Infinite loop due to stubbing. Not possible in real code.
drortirosh
reviewed
Aug 26, 2022
| const registerMethod = await this.contractInteractor.getRegisterRelayMethod(this.hubAddress, this.config.url) | ||
| let registeredUrl: string | ||
| if (this.config.privateMode) { | ||
| registeredUrl = '' |
There was a problem hiding this comment.
instead of ignoring the config url, maybe private mode should validate the url is not set
There was a problem hiding this comment.
Well, I was thinking a relay operator who wants to change from private to public would rather flip a flag than remove/add the string. Especially relevant for testing.
There was a problem hiding this comment.
I think it is far worse to have a configuration parameter ignored for not clear reason, than try to "optimize" adding a new config line in the rare case of changing "private" to "public"
drortirosh
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OG-903: Add 'blacklisted recipients' configuration field