HTTP timeout #91
Merged
HTTP timeout #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drortirosh
reviewed
Apr 8, 2019
|
Hey @drortirosh! On CircleCI, in the project (not organization) Settings, under Advanced Settings, there is an option to Build forked pull requests. |
forshtat
previously approved these changes
Apr 11, 2019
drortirosh
previously approved these changes
Apr 11, 2019
|
@drortirosh done. Note that the rebase dismissed your reviews (you can change this setting if you want in the project branch protection rules under Dismiss stale pull request approvals when new commits are pushed). |
drortirosh
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a configurable timeout to all http requests done via the HTTP wrapper.
Uses axios to manage http requests, instead of the web3 http provider, which has a configurable http timeout out of the box. The value is configurable, and set to 10 seconds by default in the RelayClient.
Fixes #73.