Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openthermgateway] Various improvements #12507

Merged
merged 2 commits into from
Mar 28, 2022
Merged

[openthermgateway] Various improvements #12507

merged 2 commits into from
Mar 28, 2022

Conversation

andrewfg
Copy link
Contributor

This PR addresses one potential issue, and makes a few slight improvements as follows..

  • As described in [openthermgateway] Gateway locks up if commands are sent too fast #12457 there was a risk of sending new commands before the gateway had finished processing prior commands. Now all commands are pipelined via a FIFO queue to prevent that.
  • Added a Thing Property to display the OpenTherm Gateway identification / version string.
  • Now a logger.warn() message is reported if the gateway watchdog timer triggers a self reset.
  • Improved logger.trace() reporting of messages read from / written to, the OpenTherm Gateway.
  • Bumped the binding version property.

Closes #12457

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

@andrewfg
[openthermgateway] various tweaks
d27d176 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg added the enhancement An enhancement or new feature for an existing add-on label Mar 22, 2022
@andrewfg andrewfg requested a review from a team March 22, 2022 12:47
jlaur
jlaur requested changes Mar 27, 2022
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, only a few minor comments.

...main/java/org/openhab/binding/openthermgateway/internal/OpenThermGatewaySocketConnector.java Outdated Show resolved Hide resolved
...main/java/org/openhab/binding/openthermgateway/internal/OpenThermGatewaySocketConnector.java Outdated Show resolved Hide resolved
...main/java/org/openhab/binding/openthermgateway/internal/OpenThermGatewaySocketConnector.java Outdated Show resolved Hide resolved
@andrewfg
[openthermgateway] adopt reviewer comments
bb9d09c 
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg requested a review from jlaur March 28, 2022 14:01
jlaur
jlaur approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for these improvements.

@jlaur jlaur merged commit 4f4dfcc into openhab:main Mar 28, 2022
@jlaur jlaur added this to the 3.3 milestone Mar 28, 2022
@andrewfg
Copy link
Contributor Author

@jlaur many thanks.

NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@andrewfg @NickWaterton
[openthermgateway] Various improvements (openhab#12507)
44b0bec 
* [openthermgateway] various tweaks

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@andrewfg @andan67
[openthermgateway] Various improvements (openhab#12507)
4e2a5b1 
* [openthermgateway] various tweaks

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@andrewfg @andrasU
[openthermgateway] Various improvements (openhab#12507)
2f9c30d 
* [openthermgateway] various tweaks

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@andrewfg @psmedley
[openthermgateway] Various improvements (openhab#12507)
57ec57b 
* [openthermgateway] various tweaks

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg deleted the openthermgateway-tweaks branch August 25, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@ArjenKorevaar ArjenKorevaar Awaiting requested review from ArjenKorevaar ArjenKorevaar is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

[openthermgateway] Gateway locks up if commands are sent too fast
2 participants
@andrewfg @jlaur