[nobohub] Initial contribution #12937

espenaf · 2022-06-14T18:39:34Z

[nobohub] Initial contribution

This binding adds support for the Glen Dimplex Nobø Hub (also know as Nobø ecoHub). Nobø Hub supports a range of electrical panel heaters, thermostats and switches from Glen Dimplex and Nobø.

README.md has information about configuration and usage.

The code should both be using the code guidelines and have run spotless on it.

Pre-built jar
Nobø Hub API Documentation 1.1
Community Discussion @ community.openhab.org
Community Discussion @ hjemmeautomasjon.no
Supported Devices

openhab-bot · 2022-06-14T19:23:04Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/nobo-hub-binding/136653/1

Signed-off-by: Espen Fossen <espenaf@junta.no>

jlaur

Thanks for your contribution! And sorry for the delay. I've added some feedback for you. There might be some inconsistency as I started the review some time ago and picked it up again today. Please also run:

mvn org.openhab.core.tools:i18n-maven-plugin:3.2.0:generate-default-translations

to generate default translations.

bundles/org.openhab.binding.nobohub/README.md

...hab.binding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/ComponentHandler.java

bundles/org.openhab.binding.nobohub/src/main/resources/OH-INF/thing/thing-types.xml

bundles/org.openhab.binding.nobohub/README.md

bundles/org.openhab.binding.nobohub/pom.xml

jlaur

Some minor comments. Posted from my phone - I'll be fully back sometime next week. :)

...ding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/NoboHubBindingConstants.java

...hab.binding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/ComponentHandler.java

* Added English and Norwegian translation for error messages * Added support for QuantityType for temperatures * Added consistent usage of property constants * Changed most logging to DEBUG or TRACE to avoid spamming logs * Changed Override to OverridePlan to avoid import clash with java.lang.Import * Lots of other small changes Signed-off-by: Espen Fossen <espenaf@junta.no>

Signed-off-by: Espen Fossen <espenaf@junta.no>

jlaur

I hope you don't mind incremental review? It allows me to push some comments sooner.

bundles/org.openhab.binding.nobohub/README.md

...hab.binding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/ComponentHandler.java

...ding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/NoboHubBindingConstants.java

espenaf · 2022-07-18T19:51:54Z

I hope you don't mind incremental review? It allows me to push some comments sooner.

No problem. I love this attention to detail, and I am learning a few tricks as we iterate on the changes.

jlaur

Commenting on null annotation issue as the castToNonNull pattern is used in many places and could be avoided.

...binding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/NoboHubBridgeHandler.java

...hab.binding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/ComponentHandler.java

jlaur · 2022-07-19T14:42:10Z

I hope you don't mind incremental review? It allows me to push some comments sooner.

No problem. I love this attention to detail, and I am learning a few tricks as we iterate on the changes.

Glad to hear. Please feel free to resolve all comments which you have provided fixes for, so we can easily track any pending issues/discussions. I will make sure to verify and reopen if needed.

...binding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/NoboHubBridgeHandler.java

bundles/org.openhab.binding.nobohub/README.md

bundles/org.openhab.binding.nobohub/src/main/resources/OH-INF/i18n/nobohub_no.properties

Signed-off-by: Espen Fossen <espenaf@junta.no>

austvik · 2022-08-17T17:40:14Z

@jlaur: I believe Espen has addressed all comments. What are the next steps here?

espenaf · 2022-08-17T17:51:24Z

@austvik: From my perspective there are two comments I have not addressed:

Remove use of Helpers.castToNonNull().
Introducing a retry mechanism in NoboHubBridgeHandler,initialize, like the use of a ScheduledFuture polling job.

I already have code for issue 1, this is running locally, but I wanted to test it a bit before pushing. Can do that shortly to get some feedback. I have not done any changes for issue 2 yet, but hopefully this might actually improve some of the disconnects it get once or twice a month.

austvik · 2022-08-17T18:13:11Z

Thanks @espenaf! Looked to me like everything had been closed for a good while. Just me itching after using it.

Retries in NoboHubBridgeHandler.initialize: Do you mean like running the scheduler that creates the connection and thread with a rate? Any stack traces or logs?

I tried to hide networking issues and reconnections in the HubCommunicationThread.

Signed-off-by: Espen Fossen <espenaf@junta.no>

espenaf · 2022-08-17T19:41:00Z

(I have tried to use the marketplace, but get "Thing factory (class org.openhab.binding.nobohub.internal.NoboHubHandlerFactory) returned null on create thing when it reports to support the thing type (nobohub:nobohub)." I'm running 3.3.0 and was thinking the only way this could fail was if it was using different ThingTypeUID versions.)

Strange, just tested with installation of the last version from marketplace, and no similar issue.

jlaur

After recent activity I went through the changed files again, and added some additional findings. It looks good, and we should be ready to merge soon. :)

...binding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/NoboHubBridgeHandler.java

...b.binding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/model/OverridePlan.java

bundles/org.openhab.binding.nobohub/src/main/resources/OH-INF/i18n/nobohub_no.properties

bundles/org.openhab.binding.nobohub/README.md

Signed-off-by: Espen Fossen <espenaf@junta.no>

jlaur

Just a few comments after looking through latest iteration of changed files. Some previously unnoticed, sorry for that.

...inding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/NoboHubHandlerFactory.java

...ing.nobohub/src/main/java/org/openhab/binding/nobohub/internal/connection/HubConnection.java

...ub/src/main/java/org/openhab/binding/nobohub/internal/discovery/NoboHubDiscoveryService.java

...binding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/NoboHubBridgeHandler.java

Signed-off-by: Espen Fossen <espenaf@junta.no>

jlaur

Quick feedback on new code.

...ub/src/main/java/org/openhab/binding/nobohub/internal/connection/HubCommunicationThread.java

Signed-off-by: Espen Fossen <espenaf@junta.no>

...ub/src/main/java/org/openhab/binding/nobohub/internal/connection/HubCommunicationThread.java

Signed-off-by: Espen Fossen <espenaf@junta.no>

...ub/src/main/java/org/openhab/binding/nobohub/internal/connection/HubCommunicationThread.java

jlaur · 2022-08-21T10:06:03Z

@espenaf - commit c48a597 recently introduced some status update changes for which I posted some comments. Do you need more time for testing these late changes, or are you ready for merging when the last comments regarding this are resolved?

espenaf · 2022-08-21T19:37:01Z

@espenaf - commit c48a597 recently introduced some status update changes for which I posted some comments. Do you need more time for testing these late changes, or are you ready for merging when the last comments regarding this are resolved?

Me and @austvik have done some more testing for the last couple of days so I think we are getting there pretty soon. Take a look at the last commit, and see if there are anything more to discuss.

...binding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/NoboHubBridgeHandler.java

Signed-off-by: Espen Fossen <espenaf@junta.no>

jlaur

Thanks again for your contribution!

Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

* Added NoboHub binding. Signed-off-by: Espen Fossen <espenaf@junta.no>

* Added NoboHub binding. Signed-off-by: Espen Fossen <espenaf@junta.no> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>

* Added NoboHub binding. Signed-off-by: Espen Fossen <espenaf@junta.no>

espenaf requested a review from a team as a code owner June 14, 2022 18:39

espenaf force-pushed the nobohub branch from c859f05 to 0b29ea0 Compare June 14, 2022 18:48

jlaur added the new binding If someone has started to work on a binding. For a new binding PR. label Jun 14, 2022

espenaf force-pushed the nobohub branch from 0b29ea0 to ee19c6e Compare June 15, 2022 12:04

Added NoboHub binding.

7c3847c

Signed-off-by: Espen Fossen <espenaf@junta.no>

espenaf force-pushed the nobohub branch from ee19c6e to 7c3847c Compare June 15, 2022 12:08

jlaur requested changes Jun 27, 2022

View reviewed changes

wborn reviewed Jul 10, 2022

View reviewed changes

bundles/org.openhab.binding.nobohub/pom.xml Outdated Show resolved Hide resolved

jlaur requested changes Jul 15, 2022

View reviewed changes

...ding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/NoboHubBindingConstants.java Outdated Show resolved Hide resolved

...hab.binding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/ComponentHandler.java Outdated Show resolved Hide resolved

espenaf force-pushed the nobohub branch 3 times, most recently from 7abaf37 to 0aeda8a Compare July 17, 2022 08:38

espenaf force-pushed the nobohub branch from 0aeda8a to 50ebd4b Compare July 17, 2022 09:12

espenaf added 2 commits July 17, 2022 11:13

Merge branch 'openhab:main' into nobohub

29064bf

Updated parent version to 3.4.0-SNAPSHOT.

4e065db

Signed-off-by: Espen Fossen <espenaf@junta.no>

jlaur requested changes Jul 17, 2022

View reviewed changes

jlaur requested changes Jul 19, 2022

View reviewed changes

jlaur reviewed Jul 19, 2022

View reviewed changes

...binding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/NoboHubBridgeHandler.java Outdated Show resolved Hide resolved

jlaur reviewed Jul 20, 2022

View reviewed changes

bundles/org.openhab.binding.nobohub/README.md Outdated Show resolved Hide resolved

jlaur reviewed Jul 20, 2022

View reviewed changes

bundles/org.openhab.binding.nobohub/src/main/resources/OH-INF/i18n/nobohub_no.properties Outdated Show resolved Hide resolved

Fixes after code review, take 2.

f775ddd

Signed-off-by: Espen Fossen <espenaf@junta.no>

espenaf force-pushed the nobohub branch from f44f8ae to f775ddd Compare July 21, 2022 17:37

Remove use of castToNonNull, using local variable where logical.

c7dc30d

Signed-off-by: Espen Fossen <espenaf@junta.no>

jlaur requested changes Aug 17, 2022

View reviewed changes

espenaf added 2 commits August 18, 2022 20:05

Fixed auto discovery.

a2636f1

Signed-off-by: Espen Fossen <espenaf@junta.no>

Fixes after code review, take 4.

99b0bfd

Signed-off-by: Espen Fossen <espenaf@junta.no>

jlaur requested changes Aug 18, 2022

View reviewed changes

espenaf force-pushed the nobohub branch from eab91cf to 498e5fc Compare August 20, 2022 06:15

Fixes after code review, take 5.

c48a597

Signed-off-by: Espen Fossen <espenaf@junta.no>

espenaf force-pushed the nobohub branch from 498e5fc to c48a597 Compare August 20, 2022 06:22

jlaur requested changes Aug 20, 2022

View reviewed changes

Fixes states and NaN checks.

fe2296b

Signed-off-by: Espen Fossen <espenaf@junta.no>

jlaur reviewed Aug 20, 2022

View reviewed changes

...ub/src/main/java/org/openhab/binding/nobohub/internal/connection/HubCommunicationThread.java Outdated Show resolved Hide resolved

jlaur reviewed Aug 20, 2022

View reviewed changes

...ub/src/main/java/org/openhab/binding/nobohub/internal/connection/HubCommunicationThread.java Outdated Show resolved Hide resolved

Fixes thing status detail after comments.

406baf3

Signed-off-by: Espen Fossen <espenaf@junta.no>

jlaur reviewed Aug 21, 2022

View reviewed changes

...ub/src/main/java/org/openhab/binding/nobohub/internal/connection/HubCommunicationThread.java Outdated Show resolved Hide resolved

jlaur reviewed Aug 21, 2022

View reviewed changes

...ub/src/main/java/org/openhab/binding/nobohub/internal/connection/HubCommunicationThread.java Outdated Show resolved Hide resolved

jlaur reviewed Aug 21, 2022

View reviewed changes

...ub/src/main/java/org/openhab/binding/nobohub/internal/connection/HubCommunicationThread.java Show resolved Hide resolved

jlaur reviewed Aug 21, 2022

View reviewed changes

...binding.nobohub/src/main/java/org/openhab/binding/nobohub/internal/NoboHubBridgeHandler.java Outdated Show resolved Hide resolved

Fixes after code review, take 6.

759c061

Signed-off-by: Espen Fossen <espenaf@junta.no>

espenaf force-pushed the nobohub branch from 99725c2 to 759c061 Compare August 21, 2022 19:52

jlaur approved these changes Aug 22, 2022

View reviewed changes

jlaur merged commit bc9cf8e into openhab:main Aug 22, 2022

jlaur added this to the 3.4 milestone Aug 22, 2022

leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022

[nobohub] Initial contribution (openhab#12937)

dad8f09

* Added NoboHub binding. Signed-off-by: Espen Fossen <espenaf@junta.no>

andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022

[nobohub] Initial contribution (openhab#12937)

26e05fe

* Added NoboHub binding. Signed-off-by: Espen Fossen <espenaf@junta.no>

andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022

[nobohub] Initial contribution (openhab#12937)

97a949d

* Added NoboHub binding. Signed-off-by: Espen Fossen <espenaf@junta.no> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>

marcelGoerentz pushed a commit to marcelGoerentz/openhab-addons that referenced this pull request Nov 14, 2022

[nobohub] Initial contribution (openhab#12937)

6d543b6

* Added NoboHub binding. Signed-off-by: Espen Fossen <espenaf@junta.no>

psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023

[nobohub] Initial contribution (openhab#12937)

d1a6a63

* Added NoboHub binding. Signed-off-by: Espen Fossen <espenaf@junta.no>

nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023

[nobohub] Initial contribution (openhab#12937)

04cc83f

* Added NoboHub binding. Signed-off-by: Espen Fossen <espenaf@junta.no>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[nobohub] Initial contribution #12937

[nobohub] Initial contribution #12937

espenaf commented Jun 14, 2022 •

edited

Loading

openhab-bot commented Jun 14, 2022

jlaur left a comment

jlaur left a comment

jlaur left a comment

espenaf commented Jul 18, 2022 •

edited

Loading

jlaur left a comment

jlaur commented Jul 19, 2022

austvik commented Aug 17, 2022

espenaf commented Aug 17, 2022 •

edited

Loading

austvik commented Aug 17, 2022

espenaf commented Aug 17, 2022

jlaur left a comment

jlaur left a comment

jlaur left a comment

jlaur commented Aug 21, 2022

espenaf commented Aug 21, 2022

jlaur left a comment

[nobohub] Initial contribution #12937

[nobohub] Initial contribution #12937

Conversation

espenaf commented Jun 14, 2022 • edited Loading

openhab-bot commented Jun 14, 2022

jlaur left a comment

Choose a reason for hiding this comment

jlaur left a comment

Choose a reason for hiding this comment

jlaur left a comment

Choose a reason for hiding this comment

espenaf commented Jul 18, 2022 • edited Loading

jlaur left a comment

Choose a reason for hiding this comment

jlaur commented Jul 19, 2022

austvik commented Aug 17, 2022

espenaf commented Aug 17, 2022 • edited Loading

austvik commented Aug 17, 2022

espenaf commented Aug 17, 2022

jlaur left a comment

Choose a reason for hiding this comment

jlaur left a comment

Choose a reason for hiding this comment

jlaur left a comment

Choose a reason for hiding this comment

jlaur commented Aug 21, 2022

espenaf commented Aug 21, 2022

jlaur left a comment

Choose a reason for hiding this comment

espenaf commented Jun 14, 2022 •

edited

Loading

espenaf commented Jul 18, 2022 •

edited

Loading

espenaf commented Aug 17, 2022 •

edited

Loading