[Easee] Initial contribution #12954

alexf2015 · 2022-06-17T15:57:15Z

The Easee binding can be used to retrieve data from the Easee Cloud API and also to control your wallbox via the Cloud API. This allows you to dynamically adjust the charge current for your car depending on production of your solar plant.

Further details can be found in the corresponding README.

lolodomo · 2022-06-17T17:38:37Z

Does not build.

alexf2015 · 2022-06-17T17:41:54Z

I do not understand the error. I builds successfully both on my local machine and on my Jenkins CI.

bundles/org.openhab.binding.easee/pom.xml

jlaur

Thanks for your contribution, the code already looks really good! I have reviewed it, and provided some feedback.

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html.

The I18N properties file must be regenerated. For reference: https://www.openhab.org/docs/developer/utils/i18n.html#generating-i18n-properties-file

The DCO is not passing, this needs to be fixed.

bundles/org.openhab.binding.easee/README.md

bundles/org.openhab.binding.easee/src/main/java/org/openhab/binding/easee/internal/Utils.java

.../main/java/org/openhab/binding/easee/internal/command/circuit/SetDynamicCircuitCurrents.java

bundles/org.openhab.binding.easee/src/main/resources/OH-INF/i18n/easee.properties

bundles/org.openhab.binding.easee/src/main/resources/OH-INF/thing/charger-channel-groups.xml

bundles/org.openhab.binding.easee/src/main/resources/OH-INF/thing/circuit-channel-groups.xml

...s/org.openhab.binding.easee/src/main/resources/OH-INF/thing/easee-readonly-channel-types.xml

.../org.openhab.binding.easee/src/main/resources/OH-INF/thing/easee-readwrite-channel-types.xml

...b.binding.easee/src/main/java/org/openhab/binding/easee/internal/connector/WebInterface.java

Signed-off-by: Alexander Friese <af944580@gmail.com>

bundles/org.openhab.binding.easee/src/main/resources/OH-INF/i18n/easee.properties

bundles/org.openhab.binding.easee/src/main/resources/OH-INF/thing/circuit-channel-groups.xml

jlaur

I have now been through all previous comments and should be up-to-date. I have reopened a few and also provided some additional feedback. I would like to go through all changed files, but didn't find time for all of it today, so please consider as partial for now.

There are still some checkstyle warnings left. You could take a look at target/code-analysis/report.html.

...ing.easee/src/main/java/org/openhab/binding/easee/internal/command/AbstractWriteCommand.java

.../main/java/org/openhab/binding/easee/internal/command/circuit/SetDynamicCircuitCurrents.java

...see/src/main/java/org/openhab/binding/easee/internal/command/circuit/SetCircuitSettings.java

.../src/main/java/org/openhab/binding/easee/internal/command/circuit/DynamicCircuitCurrent.java

.../src/main/java/org/openhab/binding/easee/internal/command/circuit/SetMaxCircuitCurrents.java

bundles/org.openhab.binding.easee/src/main/resources/OH-INF/thing/things.xml

.../org.openhab.binding.easee/src/main/resources/OH-INF/thing/easee-readwrite-channel-types.xml

...ab.binding.easee/src/main/java/org/openhab/binding/easee/internal/handler/StatusHandler.java

Signed-off-by: Alexander Friese <af944580@gmail.com> Signed-off-by: Alexander Friese <af944580@googlemail.com>

jlaur

Added inline comment for the SAT findings.

bundles/org.openhab.binding.easee/src/main/resources/OH-INF/thing/things.xml

bundles/org.openhab.binding.easee/README.md

...inding.easee/src/main/java/org/openhab/binding/easee/internal/handler/EaseeThingHandler.java

jlaur · 2022-09-06T20:38:01Z

@openhab/add-ons-maintainers - does anyone know if SLF4J_LOGGER_SHOULD_BE_NON_STATIC is intentional or false positive?

I randomly found this commit that at least documents that it was changed from static to non-static in 2017, but I don't think it's possible to find the related issue anymore in the old repo: openhab/openhab2-addons@4bb37ad

wborn · 2022-09-07T05:43:48Z

The use of non-static loggers is part of the coding guidelines:

https://www.openhab.org/docs/developer/guidelines.html#f-logging

wborn · 2022-09-07T05:54:38Z

You can find the OH2 issues in this repo: #2109

wborn · 2022-09-07T06:52:09Z

the code analysis report still links to this findbugs section which no longer exists

These findings are generated by a plugin so the section never existed in any findbugs/spotbugs documentation. We should update SAT to link to the correct documentation for these findings, e.g.:

https://www.kengo-toda.jp/findbugs-slf4j/#slf4j_logger_should_be_non_static

Signed-off-by: Alexander Friese <af944580@googlemail.com>

alexf2015 · 2022-09-08T13:56:28Z

The use of non-static loggers is part of the coding guidelines:

https://www.openhab.org/docs/developer/guidelines.html#f-logging

I changed my code but I am in doubt that this is better style...

Signed-off-by: Alexander Friese <af944580@googlemail.com>

jlaur

After the latest README updates I went over the formatted version, so provided some formatting and proof-reading comments. These are my last comments for this PR, so we should be ready to merge soon.

bundles/org.openhab.binding.easee/README.md

Signed-off-by: Alexander Friese <af944580@googlemail.com>

jlaur · 2022-09-09T20:18:38Z

@alexf2015 - there are two more open comments above. I see that they are the ones GitHub has chosen to hide, so wondering if you might have missed them for this reason? You might also simply still be considering them, just wanted to give you a heads up to not prolong the review.

bundles/org.openhab.binding.easee/README.md

alexf2015 · 2022-09-10T14:46:07Z

I was just about to change it. Meanwhile you commited the changes already. I need to signoff. Then it's done.

Signed-off-by: Alexander Friese <af944580@googlemail.com>

jlaur · 2022-09-10T14:48:10Z

I was just about to change it. Meanwhile you commited the changes already. I need to signoff. Then it's done.

Yes, sorry for that, I committed at the same time of your comment reply. Don't worry about the DCO, I can fix that when merging. Do you want to separate into two columns or not?

alexf2015 · 2022-09-10T14:49:42Z

It is ok now. I had just separated it but I am totally fine with it as it is. If you use textual configuration it is more convenient as it is now.

jlaur

Thanks again for your contribution.

Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

lolodomo · 2022-10-01T10:24:40Z

@alexf2015 : you forgot to update the CODEOWNERS file. Please create a PR to add a line in that file with you as code maintainer for this new binding.

* initial binding version Signed-off-by: Alexander Friese <af944580@gmail.com>

* initial binding version Signed-off-by: Alexander Friese <af944580@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>

* initial binding version Signed-off-by: Alexander Friese <af944580@gmail.com>

alexf2015 requested a review from a team as a code owner June 17, 2022 15:57

alexf2015 force-pushed the easee-dev branch from 6292570 to 9852696 Compare June 17, 2022 17:15

alexf2015 added the new binding If someone has started to work on a binding. For a new binding PR. label Jun 17, 2022

wborn reviewed Jul 9, 2022

View reviewed changes

bundles/org.openhab.binding.easee/pom.xml Outdated Show resolved Hide resolved

alexf2015 force-pushed the easee-dev branch 6 times, most recently from 9a7ed27 to 19a290a Compare July 17, 2022 18:06

jlaur changed the title ~~[Easee] New Binding / Initial contribution~~ [Easee] Initial contribution Jul 25, 2022

jlaur requested changes Aug 14, 2022

View reviewed changes

alexf2015 force-pushed the easee-dev branch 4 times, most recently from 777d9a1 to 7efa8a1 Compare August 20, 2022 07:34

jlaur reviewed Aug 20, 2022

View reviewed changes

...b.binding.easee/src/main/java/org/openhab/binding/easee/internal/connector/WebInterface.java Outdated Show resolved Hide resolved

initial skeleton

c83e88a

Signed-off-by: Alexander Friese <af944580@gmail.com>

alexf2015 force-pushed the easee-dev branch 3 times, most recently from 98181b4 to 0e0e4a4 Compare August 21, 2022 17:57

alexf2015 requested a review from jlaur August 21, 2022 17:58

jlaur reviewed Aug 30, 2022

View reviewed changes

bundles/org.openhab.binding.easee/src/main/resources/OH-INF/i18n/easee.properties Outdated Show resolved Hide resolved

bundles/org.openhab.binding.easee/src/main/resources/OH-INF/thing/circuit-channel-groups.xml Outdated Show resolved Hide resolved

jlaur requested changes Aug 30, 2022

View reviewed changes

alexf2015 force-pushed the easee-dev branch 2 times, most recently from c826c06 to 8f4c975 Compare September 2, 2022 17:28

Alexander Friese added 2 commits September 2, 2022 19:42

initial binding version

b1409a8

Signed-off-by: Alexander Friese <af944580@gmail.com> Signed-off-by: Alexander Friese <af944580@googlemail.com>

Readme + Code formatting

6ad0a41

Signed-off-by: Alexander Friese <af944580@gmail.com> Signed-off-by: Alexander Friese <af944580@googlemail.com>

jlaur requested changes Sep 6, 2022

View reviewed changes

remove static logger

146e47c

Signed-off-by: Alexander Friese <af944580@googlemail.com>

alexf2015 added 2 commits September 8, 2022 16:09

adopted README.md

41c0bd3

Signed-off-by: Alexander Friese <af944580@googlemail.com>

fixed warning

f56928e

Signed-off-by: Alexander Friese <af944580@googlemail.com>

jlaur requested changes Sep 8, 2022

View reviewed changes

alexf2015 added 2 commits September 9, 2022 21:34

formatting

585cf7f

Signed-off-by: Alexander Friese <af944580@googlemail.com>

changes due to review

420d7bd

Signed-off-by: Alexander Friese <af944580@googlemail.com>

jlaur reviewed Sep 10, 2022

View reviewed changes

bundles/org.openhab.binding.easee/README.md Outdated Show resolved Hide resolved

jlaur reviewed Sep 10, 2022

View reviewed changes

bundles/org.openhab.binding.easee/README.md Outdated Show resolved Hide resolved

Fix header descriptions

94fa726

Signed-off-by: Alexander Friese <af944580@googlemail.com>

alexf2015 force-pushed the easee-dev branch from 7d8b81c to 94fa726 Compare September 10, 2022 14:48

jlaur approved these changes Sep 10, 2022

View reviewed changes

jlaur merged commit 1f1de41 into openhab:main Sep 10, 2022

jlaur added this to the 3.4 milestone Sep 10, 2022

leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022

[Easee] Initial contribution (openhab#12954)

3925f2f

* initial binding version Signed-off-by: Alexander Friese <af944580@gmail.com>

andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022

[Easee] Initial contribution (openhab#12954)

65a44d4

* initial binding version Signed-off-by: Alexander Friese <af944580@gmail.com>

andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022

[Easee] Initial contribution (openhab#12954)

f08ef8e

* initial binding version Signed-off-by: Alexander Friese <af944580@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>

marcelGoerentz pushed a commit to marcelGoerentz/openhab-addons that referenced this pull request Nov 14, 2022

[Easee] Initial contribution (openhab#12954)

03b2b67

* initial binding version Signed-off-by: Alexander Friese <af944580@gmail.com>

psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023

[Easee] Initial contribution (openhab#12954)

0d1d7da

* initial binding version Signed-off-by: Alexander Friese <af944580@gmail.com>

nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023

[Easee] Initial contribution (openhab#12954)

e72806a

* initial binding version Signed-off-by: Alexander Friese <af944580@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Easee] Initial contribution #12954

[Easee] Initial contribution #12954

alexf2015 commented Jun 17, 2022

lolodomo commented Jun 17, 2022

alexf2015 commented Jun 17, 2022

jlaur left a comment •

edited

Loading

jlaur left a comment

jlaur left a comment

jlaur commented Sep 6, 2022

wborn commented Sep 7, 2022

wborn commented Sep 7, 2022

wborn commented Sep 7, 2022

alexf2015 commented Sep 8, 2022

jlaur left a comment

jlaur commented Sep 9, 2022

alexf2015 commented Sep 10, 2022

jlaur commented Sep 10, 2022

alexf2015 commented Sep 10, 2022

jlaur left a comment

lolodomo commented Oct 1, 2022

[Easee] Initial contribution #12954

[Easee] Initial contribution #12954

Conversation

alexf2015 commented Jun 17, 2022

lolodomo commented Jun 17, 2022

alexf2015 commented Jun 17, 2022

jlaur left a comment • edited Loading

Choose a reason for hiding this comment

jlaur left a comment

Choose a reason for hiding this comment

jlaur left a comment

Choose a reason for hiding this comment

jlaur commented Sep 6, 2022

wborn commented Sep 7, 2022

wborn commented Sep 7, 2022

wborn commented Sep 7, 2022

alexf2015 commented Sep 8, 2022

jlaur left a comment

Choose a reason for hiding this comment

jlaur commented Sep 9, 2022

alexf2015 commented Sep 10, 2022

jlaur commented Sep 10, 2022

alexf2015 commented Sep 10, 2022

jlaur left a comment

Choose a reason for hiding this comment

lolodomo commented Oct 1, 2022

jlaur left a comment •

edited

Loading