Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gardena] Eliminate ClassCastException (quick fix) #13004

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

andrewfg
Copy link
Contributor

Fixes #13001

This PR adds code safety checks to prevent ClassCastException from being thrown, and adds logging so that potential cases where that exception might have occurred will be logged (and as such this PR might be superseded at some point in the future).

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg added the enhancement An enhancement or new feature for an existing add-on label Jun 24, 2022
@andrewfg andrewfg requested review from lolodomo and jlaur June 24, 2022 15:29
@andrewfg andrewfg requested a review from gerrieg as a code owner June 24, 2022 15:29
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this and see if we can still fix the underlying issue afterwards.

@kaikreuzer kaikreuzer merged commit b5d7d22 into openhab:main Jun 24, 2022
@kaikreuzer kaikreuzer added this to the 3.3 milestone Jun 24, 2022
@andrewfg andrewfg deleted the 13001-gardena-quick-fix branch September 26, 2022 16:28
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gardena] ClassCastException in GardenaAccountHandler.onDeviceUpdated()
2 participants