[Konnected] Adding base URL to config to allow for manually adding thing #13251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haavar Valeur <haavar@haavar.com>
lolodomo
requested changes
Aug 12, 2022
...konnected/src/main/java/org/openhab/binding/konnected/internal/handler/KonnectedHandler.java
Outdated
Show resolved
Hide resolved
...konnected/src/main/java/org/openhab/binding/konnected/internal/handler/KonnectedHandler.java
Outdated
Show resolved
Hide resolved
...konnected/src/main/java/org/openhab/binding/konnected/internal/handler/KonnectedHandler.java
Outdated
Show resolved
Hide resolved
lolodomo
added
the
enhancement
jlaur
reviewed
Aug 12, 2022
...onnected/src/main/java/org/openhab/binding/konnected/internal/KonnectedBindingConstants.java
Outdated
Show resolved
Hide resolved
added 2 commits
August 12, 2022 15:36
…seUrl to be consistent. Signed-off-by: Haavar Valeur <haavar@haavar.com>
Signed-off-by: Haavar Valeur <haavar@haavar.com>
|
You already prepared an alert for the release notes, fine. Maybe you can adjust a little the description to be more in line with this new PR ? |
Also the README should be updated. At least things example where ipAddress is still mentioned. |
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
…ing (openhab#13251) * Adding base URL to config to allow for manually adding thing * Simplified reading of the base URL configuration. Renamed field to baseUrl to be consistent. * Changed config parameters to camel case Signed-off-by: Haavar Valeur <haavar@haavar.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…ing (openhab#13251) * Adding base URL to config to allow for manually adding thing * Simplified reading of the base URL configuration. Renamed field to baseUrl to be consistent. * Changed config parameters to camel case Signed-off-by: Haavar Valeur <haavar@haavar.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…ing (openhab#13251) * Adding base URL to config to allow for manually adding thing * Simplified reading of the base URL configuration. Renamed field to baseUrl to be consistent. * Changed config parameters to camel case Signed-off-by: Haavar Valeur <haavar@haavar.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…ing (openhab#13251) * Adding base URL to config to allow for manually adding thing * Simplified reading of the base URL configuration. Renamed field to baseUrl to be consistent. * Changed config parameters to camel case Signed-off-by: Haavar Valeur <haavar@haavar.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…ing (openhab#13251) * Adding base URL to config to allow for manually adding thing * Simplified reading of the base URL configuration. Renamed field to baseUrl to be consistent. * Changed config parameters to camel case Signed-off-by: Haavar Valeur <haavar@haavar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow for things to be manually added, and for the address of the konnected panel to be updated.
Before this change there is no configuration for the address of the konnected panel. If a panel is manually added the thing is not functional, and there is a null pointer exception on initialization.
I renamed the fields
ipAddressandhosttobaseUrlfor clarity. The field contains a URL, and not an IP address. I'm not sure if this breaks backwards compatibility, but recreation of the konnected things is anyway needed for openhab version 3.4.0.