Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hydrawise] concurrent error #13268

Merged
merged 2 commits into from
Aug 17, 2022
Merged

[Hydrawise] concurrent error #13268

merged 2 commits into from
Aug 17, 2022

Conversation

digitaldan
Copy link
Contributor

Fixes a concurrent modification exception, cleans up handler on dispose, fixes totally broken last contact channel
Fixes #13094

@digitaldan
[hydrawise] Fix concurrent modification error
c7c51dd 
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
Fixes a concurrent modification exception, cleans up handler on dispo…
53cf9c7 
…se, fixes totally broken last contact channel

Fixes openhab#13094

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Aug 15, 2022
@lolodomo
Copy link
Contributor

Do you really want to rename channel and channel type? This would be a breaking change.

@digitaldan
Copy link
Contributor Author

Do you really want to rename channel and channel type? This would be a breaking change.

This channel has never worked since the binding was rewritten, and i only found out it was broken from an off hand comment on an unrelated bug, so i think the right thing todo is to change this to be the correct channel name across the board. Since it's never worked, and only one person has mentioned it, i would not consider it a breaking change (or i would have just stuck with what was there).

lolodomo
lolodomo approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor

As users will have to recreate their things, I think this has to be tagged as a breaking change, even if only few users installed this binding.

@lolodomo lolodomo merged commit b63e420 into openhab:main Aug 17, 2022
@lolodomo lolodomo added this to the 3.4 milestone Aug 17, 2022
marcelGoerentz pushed a commit to marcelGoerentz/openhab-addons that referenced this pull request Aug 18, 2022
@digitaldan @marcelGoerentz
[Hydrawise] concurrent error (openhab#13268)
e8a0c48 
* Fixes a concurrent modification exception, cleans up handler on dispose, fixes totally broken last contact channel
Fixes openhab#13094

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Marcel Goerentz <m.goerentz@t-online.de>
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
@digitaldan @leifbladt
[Hydrawise] concurrent error (openhab#13268)
d9b9b45 
* Fixes a concurrent modification exception, cleans up handler on dispose, fixes totally broken last contact channel
Fixes openhab#13094

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@lolodomo
Copy link
Contributor

lolodomo commented Nov 1, 2022

@digitaldan : maybe you could add a compatibility note for upgrade to 3.4 ?

@digitaldan
Copy link
Contributor Author

Sure, so add an ALERT to https://github.com/openhab/openhab-distro/blob/main/distributions/openhab/src/main/resources/bin/update.lst ?

@lolodomo
Copy link
Contributor

lolodomo commented Nov 1, 2022

Yes

andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@digitaldan @andan67
[Hydrawise] concurrent error (openhab#13268)
26a54dd 
* Fixes a concurrent modification exception, cleans up handler on dispose, fixes totally broken last contact channel
Fixes openhab#13094

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@digitaldan @andrasU
[Hydrawise] concurrent error (openhab#13268)
eea3123 
* Fixes a concurrent modification exception, cleans up handler on dispose, fixes totally broken last contact channel
Fixes openhab#13094

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@digitaldan @psmedley
[Hydrawise] concurrent error (openhab#13268)
c542cdc 
* Fixes a concurrent modification exception, cleans up handler on dispose, fixes totally broken last contact channel
Fixes openhab#13094

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@digitaldan @nemerdaud
[Hydrawise] concurrent error (openhab#13268)
a8153e3 
* Fixes a concurrent modification exception, cleans up handler on dispose, fixes totally broken last contact channel
Fixes openhab#13094

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on (potentially) not backward compatible
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

[Hydrawise] Binding stops polling after error / exception
3 participants
@digitaldan @lolodomo @jlaur