[Konnected] Setting auto discovered callback URL in configuration #13295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lback URL handling Signed-off-by: Haavar Valeur <haavar@haavar.com>
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
…lback URL handling (openhab#13295) Signed-off-by: Haavar Valeur <haavar@haavar.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…lback URL handling (openhab#13295) Signed-off-by: Haavar Valeur <haavar@haavar.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…lback URL handling (openhab#13295) Signed-off-by: Haavar Valeur <haavar@haavar.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
marcelGoerentz
pushed a commit
to marcelGoerentz/openhab-addons
that referenced
this pull request
Nov 14, 2022
…lback URL handling (openhab#13295) Signed-off-by: Haavar Valeur <haavar@haavar.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
…lback URL handling (openhab#13295) Signed-off-by: Haavar Valeur <haavar@haavar.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
…lback URL handling (openhab#13295) Signed-off-by: Haavar Valeur <haavar@haavar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the auto discovered callback URL in the thing configuration. This will expose the user to the discovered URL, instead of an empty form field.
In my case the auto discovered callback URL is incorrect, and I had to dig into code / debug logs to troubleshoot. If I was exposed to the discovered callback URL in the thing settings, I may have found the issue earlier.
The auto discovered callback URL is incorrect when using reverse proxy or TLS.
Change also includes general cleanup of callback URL handling and method / variable naming.