[nuvo] Fix MPS4 flag and online status reporting #13345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
lolodomo
reviewed
Sep 3, 2022
| closeConnection(); | ||
| } else { | ||
| updateStatus(ThingStatus.ONLINE, ThingStatusDetail.NONE, this.versionString); |
There was a problem hiding this comment.
You want now to set the thing status ONLINE only when something is received through the connection ?
In practice, will a message be received systematically quickly after the connection ?
There was a problem hiding this comment.
Yes, for serial port connections, pollStatus() will cause messages to be received almost immediately. For MPS4, a ping message will arrive within a few seconds.
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
* Fix mps4 flag and online status reporting * Update missing statuses Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Fix mps4 flag and online status reporting * Update missing statuses Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
* Fix mps4 flag and online status reporting * Update missing statuses Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
marcelGoerentz
pushed a commit
to marcelGoerentz/openhab-addons
that referenced
this pull request
Nov 14, 2022
* Fix mps4 flag and online status reporting * Update missing statuses Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
* Fix mps4 flag and online status reporting * Update missing statuses Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
* Fix mps4 flag and online status reporting * Update missing statuses Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two minor issues: