Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dsmr] Made additional key for smarty meter an option #13359

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

Hilbrand
Copy link
Member

@Hilbrand Hilbrand commented Sep 6, 2022

This adds support for smart meters that require 2 keys.

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/dsmr-binding-for-austrian-smart-meters/90649/41

Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur
Copy link
Contributor

jlaur commented Sep 6, 2022

@Hilbrand - can you update the README to include this new parameter, before merging?

@lsiepel
Copy link
Contributor

lsiepel commented Sep 6, 2022

smarty meter? isn't it supposed to be smart meter ? Just saying :-)

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
@Hilbrand
Copy link
Member Author

Hilbrand commented Sep 7, 2022

@jlaur done. Added to readme

@lsiepel Originally, support for the Luxembourg smart meter was added first. They use the name smarty, and this is also in the name of the bridge. Turns out meter in Austria use the same authentication as the Luxembourg smart meters. Hence the word smarty is used instead of smart as this change was added to the smartyBridge.

@jlaur jlaur merged commit 18a41db into openhab:main Sep 7, 2022
@jlaur jlaur added this to the 3.4 milestone Sep 7, 2022
@Hilbrand Hilbrand deleted the add-2nd-key branch September 7, 2022 09:28
@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Sep 7, 2022
leifbladt pushed a commit to leifbladt/openhab-addons that referenced this pull request Oct 15, 2022
* [dsmr] Made additional key for smarty meter optional

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* [dsmr] Made additional key for smarty meter optional

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* [dsmr] Made additional key for smarty meter optional

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
marcelGoerentz pushed a commit to marcelGoerentz/openhab-addons that referenced this pull request Nov 14, 2022
* [dsmr] Made additional key for smarty meter optional

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* [dsmr] Made additional key for smarty meter optional

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* [dsmr] Made additional key for smarty meter optional

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants