[Konnected] Taking configured onValue into account when sending status to actuator #13360
Conversation
|
@jlaur can you review this PR when you get a chance? I have a few other changes queued, and I want to avoid large PRs and merge conflicts. Let me know if I can clarify anything. Thanks. |
Sure.
That's a good approach! And it will usually also result in faster reviews.
Perhaps you could mention this onValue in the README as currently it seems undocumented? That would help me also understanding the logic behind it. |
Signed-off-by: Haavar Valeur <haavar@haavar.com>
Signed-off-by: Haavar Valeur <haavar@haavar.com>
haavar
force-pushed
the
actuator_state
branch
from
4d3ea0d
to
7d84280
Compare
|
Thanks. I did not mean to nag, I just saw you approve my other (newer) PR, and wanted to see if there was any issues with this. Added a paragraph about the onValue in the readme. The name for this parameter may not be the best. It's really for controlling whether the ON or OFF value in openhab corresponds to high or low signal on the panel. I used this setting when connecting a low level triggered relay board. That means that the relay turns on when the signal is set to 0V (ground / low). Since the onValue setting was not taken into account, I had to remember that for that zone ON was turning the relay OFF and vise versa. It got pretty confusing when writing rules using that zone. After fixing the onValue settings, the rules became much easier to understand. |
...konnected/src/main/java/org/openhab/binding/konnected/internal/handler/KonnectedHandler.java
Show resolved
Hide resolved
|
@haavar - I will let @volfan6415 as code owner respond to the open comment/review the PR before merging. |
…s to actuator (openhab#13360) * Taking configured onvalue into account when sending status to actuator * Added documentation for onValue configuration Signed-off-by: Haavar Valeur <haavar@haavar.com>
…s to actuator (openhab#13360) * Taking configured onvalue into account when sending status to actuator * Added documentation for onValue configuration Signed-off-by: Haavar Valeur <haavar@haavar.com>
…s to actuator (openhab#13360) * Taking configured onvalue into account when sending status to actuator * Added documentation for onValue configuration Signed-off-by: Haavar Valeur <haavar@haavar.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
…s to actuator (openhab#13360) * Taking configured onvalue into account when sending status to actuator * Added documentation for onValue configuration Signed-off-by: Haavar Valeur <haavar@haavar.com>
…s to actuator (openhab#13360) * Taking configured onvalue into account when sending status to actuator * Added documentation for onValue configuration Signed-off-by: Haavar Valeur <haavar@haavar.com>
…s to actuator (openhab#13360) * Taking configured onvalue into account when sending status to actuator * Added documentation for onValue configuration Signed-off-by: Haavar Valeur <haavar@haavar.com>
Fixing a bug where the configured onValue for the channel was ignored when sending a status to the panel. The onValue configuration was only considered when receiving a status from the panel. Honoring the onValue configuration is important when using the standard relay boards recommended by Konnected that are low triggered.