[unifi] Fix portoverride to not remove any other data #13362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user has configured additional settings on a PoE port, like name. These settings where lost when changing the PoEPort status in openHAB. This was because in the binding only some information of the override was stored and when writing th new state this information would have been send too. In this change the object to store the override has been replaced by a plain json object. Therefor we don't have to know what is in it and all information is kept. Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Hilbrand
force-pushed
the
fix-poeport
branch
from
11d6783
to
e7ca175
Compare
|
Confirmation of test: https://community.openhab.org/t/unifi-binding-beta/131156/87 |
leifbladt
pushed a commit
to leifbladt/openhab-addons
that referenced
this pull request
Oct 15, 2022
When a user has configured additional settings on a PoE port, like name. These settings where lost when changing the PoEPort status in openHAB. This was because in the binding only some information of the override was stored and when writing the new state this information would have been sent too. In this change the object to store the override has been replaced by a plain json object. Therefore we don't have to know what is in it and all information is kept. Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
When a user has configured additional settings on a PoE port, like name. These settings where lost when changing the PoEPort status in openHAB. This was because in the binding only some information of the override was stored and when writing the new state this information would have been sent too. In this change the object to store the override has been replaced by a plain json object. Therefore we don't have to know what is in it and all information is kept. Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
When a user has configured additional settings on a PoE port, like name. These settings where lost when changing the PoEPort status in openHAB. This was because in the binding only some information of the override was stored and when writing the new state this information would have been sent too. In this change the object to store the override has been replaced by a plain json object. Therefore we don't have to know what is in it and all information is kept. Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
marcelGoerentz
pushed a commit
to marcelGoerentz/openhab-addons
that referenced
this pull request
Nov 14, 2022
When a user has configured additional settings on a PoE port, like name. These settings where lost when changing the PoEPort status in openHAB. This was because in the binding only some information of the override was stored and when writing the new state this information would have been sent too. In this change the object to store the override has been replaced by a plain json object. Therefore we don't have to know what is in it and all information is kept. Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
psmedley
pushed a commit
to psmedley/openhab-addons
that referenced
this pull request
Feb 23, 2023
When a user has configured additional settings on a PoE port, like name. These settings where lost when changing the PoEPort status in openHAB. This was because in the binding only some information of the override was stored and when writing the new state this information would have been sent too. In this change the object to store the override has been replaced by a plain json object. Therefore we don't have to know what is in it and all information is kept. Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Feb 28, 2023
When a user has configured additional settings on a PoE port, like name. These settings where lost when changing the PoEPort status in openHAB. This was because in the binding only some information of the override was stored and when writing the new state this information would have been sent too. In this change the object to store the override has been replaced by a plain json object. Therefore we don't have to know what is in it and all information is kept. Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user has configured additional settings on a PoE port, like name. These settings where lost when changing the PoEPort status in openHAB. This was because in the binding only some information of the override was stored and when writing the new state this information would have been send too. In this change the object to store the override has been replaced by a plain json object. Therefor we don't have to know what is in it and all information is kept.