[avmfritz] Add light blub color temperature support

[vich-667]

Added an new channel to HAN_FUN_COLOR_BULB to conrol color temperature. This can be used to set the white color for the FRITZ!DECT 500 or to set it back to white mode if it is in color mode.

• adds a color tempeature channel
• fixes some on off behavior, what was somehow async between OH and the real world Thing

Should fix: #14287

Thanks to @sommer for posting the base of this code to #12427

[lolodomo]

@ccutrer you are our specialist for color temperature ;) Didn't you implement something that should avoid the hardcoded conversion of values proposed in that PR ?

[ccutrer]

I would highly recommend that you add both colorTemperature (as a dimmer), and colorTemperatureAbs (as a Number:Temperature, and system:color-temperature-abs type). You will need to use QuantityType (in Kelvin) when posting updates of your channel's state, and toInvertibleUnit (converting to Kelvin) when accepting commands to make sure automatic unit conversions work (some people will prefer to work in mired/mirek, and some will prefer to work in Kelvin).

There's nothing to help you scale between percent and temperature in Kelvin as in this PR. It looks like your device supports setting a color temperature directly in Kelvin. Does your device not support arbitrary color temperatures, only the few given in your long if/else if structure? If it supports arbitrary, you should definitely just use math and scale the percent value. You may want to do the scaling in mireds instead of Kelvin, since mireds have the nice property that any given interval of say 50 mireds will be the same perceptible change in color, whereas in Kelvin the higher you go in the scale, the larger the interval to achieve the same perceptible change (i.e. 2700K to 3000K is about the same perceptible difference as 5000K to 6000K).

[vich-667]

I would highly recommend that you add both colorTemperature (as a dimmer), and colorTemperatureAbs (as a Number:Temperature, and system:color-temperature-abs type). You will need to use QuantityType (in Kelvin) when posting updates of your channel's state, and toInvertibleUnit (converting to Kelvin) when accepting commands to make sure automatic unit conversions work (some people will prefer to work in mired/mirek, and some will prefer to work in Kelvin).

There's nothing to help you scale between percent and temperature in Kelvin as in this PR. It looks like your device supports setting a color temperature directly in Kelvin. Does your device not support arbitrary color temperatures, only the few given in your long if/else if structure? If it supports arbitrary, you should definitely just use math and scale the percent value. You may want to do the scaling in mireds instead of Kelvin, since mireds have the nice property that any given interval of say 50 mireds will be the same perceptible change in color, whereas in Kelvin the higher you go in the scale, the larger the interval to achieve the same perceptible change (i.e. 2700K to 3000K is about the same perceptible difference as 5000K to 6000K).

I will have a look here. I need to test this out if other color temps are working and math can be used. This might take me some days, because currently I'm fighting with some issue that I can not debug.

[vich-667]

I would highly recommend that you add both colorTemperature (as a dimmer), and colorTemperatureAbs (as a Number:Temperature, and system:color-temperature-abs type). You will need to use QuantityType (in Kelvin) when posting updates of your channel's state, and toInvertibleUnit (converting to Kelvin) when accepting commands to make sure automatic unit conversions work (some people will prefer to work in mired/mirek, and some will prefer to work in Kelvin).

I had some look to the hue binding and tried to add that additional channel. At to me it worked fine.

There's nothing to help you scale between percent and temperature in Kelvin as in this PR. It looks like your device supports setting a color temperature directly in Kelvin. Does your device not support arbitrary color temperatures, only the few given in your long if/else if structure? If it supports arbitrary, you should definitely just use math and scale the percent value. You may want to do the scaling in mireds instead of Kelvin, since mireds have the nice property that any given interval of say 50 mireds will be the same perceptible change in color, whereas in Kelvin the higher you go in the scale, the larger the interval to achieve the same perceptible change (i.e. 2700K to 3000K is about the same perceptible difference as 5000K to 6000K).

The light blub type I have only supports dedicated numbers. Bacause I can configure any value and it jumps to a supported one, I changed to math.

Because the original steps are in between the scaling in Kelvin and Mired, I used the Mired as you reccomended.

[ccutrer]

Color temp stuff all looks good to me, except perhaps using some consts for min/max mireds

[vich-667]

Color temp stuff all looks good to me, except perhaps using some consts for min/max mireds

As I put to the inline comment the AHA-HTTP-Inteface docu only gave me that 2700K and 6500K, therefore I didn't introduced any additional magic numbers byside of that ones.

Of course It migt not make sense to calculate the min/max mireds dynamically. If you prefer I also can replace them by const values.

[jlaur]

For the new channels added, please add update instructions. For reference, see #14572 and #14587. I believe you can keep target version 1.

[vich-667]

@jlaur: I added. can you please check if it's OK?

[jlaur]

I added. can you please check if it's OK?

See https://github.com/openhab/openhab-docs/blob/7bd66d601e0d1421dd18b22e0132ee406127158b/developers/bindings/thing-xml.md#updating-thing-types and https://www.openhab.org/schemas/update-description-1.0.0.xsd. You will need to use add-channel for a new channel. Also, you need to set the thingTypeVersion property.

[vich-667]

@jlaur: Thanks for your hint, I think now I got it.

[vich-667]

@lolodomo or @cweitkamp: can you please give some feedback here. I think all given comments are fixed.

[lolodomo]

Just one remark about naming conventions (channel id).

[lolodomo]

LGTM, thank upu