fix some review comments

Signed-off-by: Tobias Lange <vich-667@gmx.de>
openhab · Mar 12, 2023 · 355aced · 355aced
1 parent 2ffd1d5
commit 355aced
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/...src/main/java/org/openhab/binding/avmfritz/internal/handler/AVMFritzBaseThingHandler.java b/...src/main/java/org/openhab/binding/avmfritz/internal/handler/AVMFritzBaseThingHandler.java
@@ -263,7 +263,7 @@ private void updateDimmableLight(@Nullable LevelControlModel levelControlModel)
 
     private void updateColorLight(@Nullable ColorControlModel colorControlModel,
             @Nullable LevelControlModel levelControlModel, @Nullable SimpleOnOffModel simpleOnOff) {
-        if (colorControlModel != null && levelControlModel != null) {
+        if (colorControlModel != null && levelControlModel != null && simpleOnOff != null) {
             DecimalType hue = new DecimalType(colorControlModel.hue);
             PercentType saturation = ColorControlModel.toPercent(colorControlModel.saturation);
             PercentType brightness;
@@ -526,12 +526,12 @@ public void handleCommand(ChannelUID channelUID, Command command) {
                 }
                 break;
             case CHANNEL_COLORTEMPERATURE:
-                BigDecimal color_temperature = null;
+                BigDecimal colorTemperature = null;
                 if (command instanceof PercentType) {
-                    color_temperature = ((PercentType) command).toBigDecimal();
+                    colorTemperature = ((PercentType) command).toBigDecimal();
                 }
-                if (color_temperature != null) {
-                    int pct = color_temperature.intValue();
+                if (colorTemperature != null) {
+                    int pct = colorTemperature.intValue();
                     int temperature = 2700;
                     if (pct <= 6) {
                         temperature = 2700;