[avmfritz] Use system channel types and decrease minimum polling interval #14587
Conversation
cweitkamp
added
the
enhancement
cweitkamp
changed the title
cweitkamp
force-pushed
the
feature-avmfritz-improvements
branch
from
c1fa1d2 to
1a5accd
Compare
bundles/org.openhab.binding.avmfritz/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.avmfritz/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.avmfritz/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
...mfritz/src/main/java/org/openhab/binding/avmfritz/internal/handler/Powerline546EHandler.java
Show resolved
Hide resolved
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
force-pushed
the
feature-avmfritz-improvements
branch
from
1a5accd to
4fb55d3
Compare
| <channel id="actual_temp" typeId="system.indoor-temperature"> | ||
| <label>Current Temperature</label> | ||
| <description>Current measured temperature.</description> | ||
| </channel> |
There was a problem hiding this comment.
If you change the channel-type, please add update instructions for existing things.
There was a problem hiding this comment.
They are already part of this PR. Or did I miss one of the changed Things.
There was a problem hiding this comment.
And I already forgot that I reviewed them. 😳
There was a problem hiding this comment.
By the way: I missed to change the channel types in the https://github.com/openhab/openhab-addons/blob/4fb55d3350dfb3767abf1e1f6b5dfa220be05fc7/bundles/org.openhab.binding.avmfritz/src/main/resources/OH-INF/thing/bridge-types.xml. Will do that.
Do the update instructions work for bridge-types too? I am not able to add tag <bridge-types> in the instructions.xml.
There was a problem hiding this comment.
thing-type should also work for bridges.
There was a problem hiding this comment.
Alright. If so this PR is completed from my side.
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
…rval (openhab#14587) * Use system default channel types * Changed minimum polling interval to 1s Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
|
Hi, is there any possibility to test it upfront or do I have to wait until OH 4.0.0 Milestone 5? |
Closes #13655
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de