Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openwebnet] Light switch updates are now triggered #14390

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

mvalla
Copy link
Contributor

@mvalla mvalla commented Feb 13, 2023

Removed the variable used to check if switch state has changed.
Now for each light switch update updateState() is correctly called on switch channel
Fixes #14102

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla mvalla added the bug An unexpected problem or unintended behavior of an add-on label Feb 13, 2023
@mvalla mvalla requested a review from lolodomo February 13, 2023 18:34
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I have added a very minor completely optional suggestion.

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit bbb4c3e into openhab:main Feb 13, 2023
@jlaur jlaur added this to the 4.0 milestone Feb 13, 2023
@jlaur jlaur changed the title [openwebnet] light switch updates are now triggered [openwebnet] Light switch updates are now triggered Feb 13, 2023
SMHRambo pushed a commit to SMHRambo/openhab-addons that referenced this pull request Feb 14, 2023
* [openwebnet] light switch updates are now triggered

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla mvalla deleted the openwebnet-switch-update branch February 26, 2023 16:44
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
* [openwebnet] light switch updates are now triggered

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
* [openwebnet] light switch updates are now triggered

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@mvalla
Copy link
Contributor Author

mvalla commented Apr 2, 2023

@jlaur I suggest to backport this to 3.4.x, thanks.

jlaur pushed a commit that referenced this pull request Apr 2, 2023
* [openwebnet] light switch updates are now triggered

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Apr 2, 2023
@jlaur
Copy link
Contributor

jlaur commented Apr 2, 2023

I suggest to backport this to 3.4.x, thanks.

Done.

FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
* [openwebnet] light switch updates are now triggered

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[openwebnet] Update trigger does not work on Switch channel
2 participants