-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openwebnet] Light switch updates are now triggered #14390
Conversation
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! I have added a very minor completely optional suggestion.
...src/main/java/org/openhab/binding/openwebnet/internal/handler/OpenWebNetLightingHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [openwebnet] light switch updates are now triggered Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] light switch updates are now triggered Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] light switch updates are now triggered Signed-off-by: Massimo Valla <mvcode00@gmail.com>
@jlaur I suggest to backport this to 3.4.x, thanks. |
* [openwebnet] light switch updates are now triggered Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Done. |
* [openwebnet] light switch updates are now triggered Signed-off-by: Massimo Valla <mvcode00@gmail.com>
Removed the variable used to check if switch state has changed.
Now for each light switch update
updateState()
is correctly called on switch channelFixes #14102