Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ecobee] Remove org.apache.commons #14403

Merged
merged 4 commits into from
Feb 22, 2023
Merged

[ecobee] Remove org.apache.commons #14403

merged 4 commits into from
Feb 22, 2023

Conversation

lsiepel
Copy link
Contributor

@lsiepel lsiepel commented Feb 16, 2023

  • Remove dependency on apache.commons

Untested, minor refactoring from only from code perspective

@lsiepel
Remopve org.apache.commons
13fa994 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel
Remove dependency on WordUtils.capitalize
7dced1e 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel
forgotten annotation
8f4b594 
Signed-off-by: lsiepel <leosiepel@gmail.com>
@lsiepel lsiepel mentioned this pull request Feb 16, 2023
Open
mhilbush
mhilbush approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@mhilbush mhilbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

These changes all LGTM.

It's a bit unfortunate that there's no common ExceptionUtils class in core. I would imagine this binding isn't the only one that needs to get the root cause exception.

Same for the utility to capitalize words.

@lsiepel lsiepel changed the title [ecobee] Remopve org.apache.commons [ecobee] Remove org.apache.commons Feb 16, 2023
@lsiepel
Fix comment
c3da71c 
Signed-off-by: lsiepel <leosiepel@gmail.com>
lolodomo
lolodomo approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit 1c35ebc into openhab:main Feb 22, 2023
@lolodomo lolodomo added the enhancement An enhancement or new feature for an existing add-on label Feb 22, 2023
@lolodomo lolodomo added this to the 4.0 milestone Feb 22, 2023
@lsiepel lsiepel deleted the ecobee-apache branch February 22, 2023 13:43
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@lsiepel @nemerdaud
[ecobee] Remove org.apache.commons (openhab#14403)
b70a17e 
Signed-off-by: lsiepel <leosiepel@gmail.com>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@lsiepel @renescherer
[ecobee] Remove org.apache.commons (openhab#14403)
287c57d 
Signed-off-by: lsiepel <leosiepel@gmail.com>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@lsiepel @FordPrfkt
[ecobee] Remove org.apache.commons (openhab#14403)
8fd94cf 
Signed-off-by: lsiepel <leosiepel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbush mhilbush mhilbush approved these changes

@lolodomo lolodomo lolodomo approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lsiepel @lolodomo @mhilbush