List spotless plugin in plugins section, not only pluginManagement section #6867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cition Signed-off-by: Arne Seime <arne.seime@gmail.com>
Travis tests were successfulHey @seime, |
cweitkamp
reviewed
Jan 19, 2020
There was a problem hiding this comment.
LGTM. Thanks.
See also openhab/openhab-core#1334 (review):
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14.282 s
[INFO] Finished at: 2020-01-19T12:56:56+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.diffplug.spotless:spotless-maven-plugin:1.24.3:check (codestyle_check) on project org.openhab.addons.features.karaf.openhab-addons: The following files had format violations:
[ERROR] src/main/resources/header.xml
[ERROR] @@ -1,19 +1,7 @@
[ERROR] <?xml·version="1.0"·encoding="UTF-8"?>
[ERROR] -<!--
[ERROR] -
[ERROR] -\tCopyright·(c)·2010-2020·Contributors·to·the·openHAB·project
[ERROR] -
[ERROR] -\tSee·the·NOTICE·file(s)·distributed·with·this·work·for·additional
[ERROR] -\tinformation.
[ERROR] -
[ERROR] -\tThis·program·and·the·accompanying·materials·are·made·available·under·the
[ERROR] -\tterms·of·the·Eclipse·Public·License·2.0·which·is·available·at
[ERROR] -\thttp://www.eclipse.org/legal/epl-2.0
[ERROR] -
[ERROR] -\tSPDX-License-Identifier:·EPL-2.0
[ERROR] -
[ERROR] --->
[ERROR] +<!--·Copyright·(c)·2010-2020·Contributors·to·the·openHAB·project·See·the·NOTICE·file(s)·distributed·with·this·work·for·additional
[ERROR] +\tinformation.·This·program·and·the·accompanying·materials·are·made·available·under·the·terms·of·the·Eclipse·Public·License
[ERROR] +\t2.0·which·is·available·at·http://www.eclipse.org/legal/epl-2.0·SPDX-License-Identifier:·EPL-2.0·-->
[ERROR] <features·name="${project.artifactId}-${project.version}"·xmlns="http://karaf.apache.org/xmlns/features/v1.4.0">
[ERROR]
[ERROR] -····<repository>mvn:org.openhab.core.features.karaf/org.openhab.core.features.karaf.openhab-core/${ohc.version}/xml/features</repository>
[ERROR] -
[ERROR] +\t<repository>mvn:org.openhab.core.features.karaf/org.openhab.core.features.karaf.openhab-core/${ohc.version}/xml/features</repository>
[ERROR] Run 'mvn spotless:apply' to fix these violations.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :org.openhab.addons.features.karaf.openhab-addons
J-N-K
added
rebuild
J-N-K
approved these changes
Jan 23, 2020
|
@cweitkamp Travis and Jenkins agree, can we merge here? |
|
Yes, we can merge this. But the build will fail on the |
cweitkamp
pushed a commit
to cweitkamp/openhab-addons
that referenced
this pull request
Jan 25, 2020
…uginManagement secition (openhab#6867) Signed-off-by: Arne Seime <arne.seime@gmail.com>
|
I cherry-picked this PR into the master branch (see 2807b56). |
Hilbrand
added a commit
to Hilbrand/openhab-distro
that referenced
this pull request
Jan 27, 2020
Related to changes in openHAB-addons: openhab/openhab-addons#6867 Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
kaikreuzer
pushed a commit
to openhab/openhab-distro
that referenced
this pull request
Jan 27, 2020
Related to changes in openHAB-addons: openhab/openhab-addons#6867 Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
hawkeye-bot
pushed a commit
to hawkeye-bot/openhab-addons
that referenced
this pull request
Jan 30, 2020
…uginManagement secition (openhab#6867) Signed-off-by: Arne Seime <arne.seime@gmail.com> Signed-off-by: hoeckxer <hawkeyenl@yahoo.com>
andibraeu
pushed a commit
to andibraeu/openhab-addons
that referenced
this pull request
Feb 17, 2020
…uginManagement secition (openhab#6867) Signed-off-by: Arne Seime <arne.seime@gmail.com>
leluna
pushed a commit
to leluna/openhab2-addons
that referenced
this pull request
Mar 21, 2020
…uginManagement secition (openhab#6867) Signed-off-by: Arne Seime <arne.seime@gmail.com> Signed-off-by: leluna <hengrui.jiang@googlemail.com>
Hans-Reiner
pushed a commit
to Hans-Reiner/openhab2-addons
that referenced
this pull request
Apr 11, 2020
…uginManagement secition (openhab#6867) Signed-off-by: Arne Seime <arne.seime@gmail.com> Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>
ramack
pushed a commit
to ramack/openhab-addons
that referenced
this pull request
May 31, 2020
…uginManagement secition (openhab#6867) Signed-off-by: Arne Seime <arne.seime@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…uginManagement secition (openhab#6867) Signed-off-by: Arne Seime <arne.seime@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…uginManagement secition (openhab#6867) Signed-off-by: Arne Seime <arne.seime@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…uginManagement secition (openhab#6867) Signed-off-by: Arne Seime <arne.seime@gmail.com>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
…uginManagement secition (openhab#6867) Signed-off-by: Arne Seime <arne.seime@gmail.com>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
…uginManagement secition (openhab#6867) Signed-off-by: Arne Seime <arne.seime@gmail.com> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin was only defined/configured, not prepared for actual lifecycle use (listed in the build/plugins section)
Related to openhab/openhab-core#1303 only this is for the addons repo