[nanoleaf] reduce layout logs, fix wrong type detection, add discovery props #7180

stefan-hoehn · 2020-03-15T17:00:56Z

Reduce layout logging by manual triggering
Add more test for inconsistent layout response from device
Fix wrong type detection for canvas
Fix rediscovery end handling (could have put controller offline)
Add model/vendor properties automatically if things configured manually in a static things file
Some code cleanup

Signed-off-by: Stefan Höhn stefan@andreaundstefanhoehn.de

…y props - Reduce layout logging by manual triggering - Add more test for inconsistent layout response from device - Fix wrong type detection for canvas - Fix rediscovery end handling (could have put controller offline) - Add model/vendor properties automatically if things configured manually in a static things file - Some code cleanup Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>

TravisBuddy · 2020-03-15T17:05:20Z

Travis tests were successful

Hey @stefan-hoehn,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

raepple

LGTM

cpmeister · 2020-03-15T17:47:31Z

...f/src/main/java/org/openhab/binding/nanoleaf/internal/handler/NanoleafControllerHandler.java

+                @Nullable
+                Layout layout = controllerInfo.getPanelLayout().getLayout();
+                String layoutView = (layout != null) ? layout.getLayoutView() : "";
+                logger.info("Panel layout and ids for controller {} \n{}", thing.getUID(), layoutView);


please remove this logging statement, or set to debug

In this case it is exactly the intention to have it on "info" as it is the standard logging setting (most OH users don't know how to change the log setting in karaf as it is rather advanced). It used to be info already before but was logged very often and filled the log. Now it is only logged upon request if needed intentionally as information for a standard user which is usually only done when you change the layout of your canvas. Hope that clarifies it :-)

stefan-hoehn · 2020-03-15T20:47:01Z

Thanks, @cpmeister 👍

…y props (openhab#7180) - Reduce layout logging by manual triggering - Add more test for inconsistent layout response from device - Fix wrong type detection for canvas - Fix rediscovery end handling (could have put controller offline) - Add model/vendor properties automatically if things configured manually in a static things file - Some code cleanup Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de> Co-authored-by: Stefan Höhn <stefan@andreaundstefanhoehn.de> Signed-off-by: leluna <hengrui.jiang@googlemail.com>

…y props (openhab#7180) - Reduce layout logging by manual triggering - Add more test for inconsistent layout response from device - Fix wrong type detection for canvas - Fix rediscovery end handling (could have put controller offline) - Add model/vendor properties automatically if things configured manually in a static things file - Some code cleanup Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de> Co-authored-by: Stefan Höhn <stefan@andreaundstefanhoehn.de> Signed-off-by: Hans-Reiner Hoffmann <hans-reiner.hoffmann@gmx.de>

…y props (openhab#7180) - Reduce layout logging by manual triggering - Add more test for inconsistent layout response from device - Fix wrong type detection for canvas - Fix rediscovery end handling (could have put controller offline) - Add model/vendor properties automatically if things configured manually in a static things file - Some code cleanup Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de> Co-authored-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>

…y props (openhab#7180) - Reduce layout logging by manual triggering - Add more test for inconsistent layout response from device - Fix wrong type detection for canvas - Fix rediscovery end handling (could have put controller offline) - Add model/vendor properties automatically if things configured manually in a static things file - Some code cleanup Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de> Co-authored-by: Stefan Höhn <stefan@andreaundstefanhoehn.de> Signed-off-by: Daan Meijer <daan@studioseptember.nl>

…y props (openhab#7180) - Reduce layout logging by manual triggering - Add more test for inconsistent layout response from device - Fix wrong type detection for canvas - Fix rediscovery end handling (could have put controller offline) - Add model/vendor properties automatically if things configured manually in a static things file - Some code cleanup Signed-off-by: Stefan Höhn <stefan@andreaundstefanhoehn.de> Co-authored-by: Stefan Höhn <stefan@andreaundstefanhoehn.de>

stefan-hoehn requested a review from raepple as a code owner March 15, 2020 17:00

raepple approved these changes Mar 15, 2020

View reviewed changes

cpmeister requested changes Mar 15, 2020

View reviewed changes

cpmeister approved these changes Mar 15, 2020

View reviewed changes

cpmeister merged commit cc22605 into openhab:2.5.x Mar 15, 2020

kaikreuzer added the bug An unexpected problem or unintended behavior of an add-on label Mar 18, 2020

kaikreuzer added this to the 2.5.3 milestone Mar 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[nanoleaf] reduce layout logs, fix wrong type detection, add discovery props #7180

[nanoleaf] reduce layout logs, fix wrong type detection, add discovery props #7180

stefan-hoehn commented Mar 15, 2020

TravisBuddy commented Mar 15, 2020

raepple left a comment

cpmeister Mar 15, 2020

stefan-hoehn Mar 15, 2020 •

edited

Loading

stefan-hoehn commented Mar 15, 2020

[nanoleaf] reduce layout logs, fix wrong type detection, add discovery props #7180

[nanoleaf] reduce layout logs, fix wrong type detection, add discovery props #7180

Conversation

stefan-hoehn commented Mar 15, 2020

TravisBuddy commented Mar 15, 2020

Travis tests were successful

raepple left a comment

Choose a reason for hiding this comment

cpmeister Mar 15, 2020

Choose a reason for hiding this comment

stefan-hoehn Mar 15, 2020 • edited Loading

Choose a reason for hiding this comment

stefan-hoehn commented Mar 15, 2020

stefan-hoehn Mar 15, 2020 •

edited

Loading