-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rfxcom] Removed dependency on 'org.apache.commons.io.IOUtils' #7729
Conversation
Relative to openhab#7722 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
This was pushed without a working maven buiuld (Maven build is currently not working due to download failures). |
Travis tests were successfulHey @lolodomo, |
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Using the offline mode ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For debug statements I would personally log the exception (instead of only the message) but the pattern is not uncommon here, so LGTM. |
…ab#7729) Related to openhab#7722 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
…ab#7729) Related to openhab#7722 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
…ab#7729) Related to openhab#7722 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: CSchlipp <christian@schlipp.de>
…ab#7729) Related to openhab#7722 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
…ab#7729) Related to openhab#7722 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
…ab#7729) Related to openhab#7722 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
…ab#7729) Related to openhab#7722 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
…ab#7729) Related to openhab#7722 Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Daan Meijer <daan@studioseptember.nl>
…ab#7729) Related to openhab#7722 Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Relative to #7722
Signed-off-by: Laurent Garnier lg.hc@free.fr