Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' #7734

Merged
merged 2 commits into from
May 25, 2020
Merged

[plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' #7734

merged 2 commits into from
May 25, 2020

Conversation

lolodomo
Copy link
Contributor

Relative to #7722

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo requested a review from wborn as a code owner May 22, 2020 10:25
@lolodomo lolodomo changed the title [plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' [WIP][plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' May 23, 2020
@lolodomo
[plugwise] Removed dependency on 'org.apache.commons.io.IOUtils'
3f04995 
Relative to openhab#7722

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@openhab openhab deleted a comment from TravisBuddy May 25, 2020
@lolodomo lolodomo changed the title [WIP][plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' [plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' May 25, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

J-N-K
J-N-K requested changes May 25, 2020
View reviewed changes
...ugwise/src/main/java/org/openhab/binding/plugwise/internal/PlugwiseCommunicationContext.java Outdated
@@ -97,8 +96,20 @@ public void closeSerialPort() {
SerialPort localSerialPort = serialPort;
if (localSerialPort != null) {
try {
IOUtils.closeQuietly(localSerialPort.getInputStream());
IOUtils.closeQuietly(localSerialPort.getOutputStream());
if (localSerialPort.getInputStream() != null) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to assign a local variable here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@lolodomo
Local variables
0702c7d 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

cpmeister
cpmeister approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 8900180 into openhab:2.5.x May 25, 2020
@cpmeister cpmeister added this to the 2.5.6 milestone May 25, 2020
@lolodomo lolodomo deleted the plugwise_ioutils branch May 25, 2020 18:17
bodiroga pushed a commit to bodiroga/openhab-addons that referenced this pull request May 26, 2020
@lolodomo @bodiroga
[plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
2c81eb4 
…nhab#7734)

* [plugwise] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722
* Local variables

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@lolodomo @LoungeFlyZ
[plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
023194a 
…nhab#7734)

* [plugwise] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722
* Local variables

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@lolodomo @J-N-K
[plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
0e35395 
…nhab#7734)

* [plugwise] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722
* Local variables

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@lolodomo @CSchlipp
[plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
387e89f 
…nhab#7734)

* [plugwise] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722
* Local variables

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: CSchlipp <christian@schlipp.de>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
d04d907 
…nhab#7734)

* [plugwise] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722
* Local variables

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
9dcaa15 
…nhab#7734)

* [plugwise] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722
* Local variables

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
790e90f 
…nhab#7734)

* [plugwise] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722
* Local variables

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
48b2205 
…nhab#7734)

* [plugwise] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722
* Local variables

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@lolodomo @DaanMeijer
[plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
954a811 
…nhab#7734)

* [plugwise] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722
* Local variables

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: Daan Meijer <daan@studioseptember.nl>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@lolodomo @markus7017
[plugwise] Removed dependency on 'org.apache.commons.io.IOUtils' (ope…
f9bcbb0 
…nhab#7734)

* [plugwise] Removed dependency on 'org.apache.commons.io.IOUtils'

Relative to openhab#7722
* Local variables

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K requested changes

@cpmeister cpmeister cpmeister approved these changes

@wborn wborn Awaiting requested review from wborn wborn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.6
Development

Successfully merging this pull request may close these issues.
4 participants
@lolodomo @TravisBuddy @cpmeister @J-N-K