Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jdbc and mapdb persistence build errors #7763

Merged
merged 1 commit into from
May 24, 2020

Conversation

wborn
Copy link
Member

@wborn wborn commented May 24, 2020

The javassist dependency previously provided by the jetty-all bundle is no longer available causing the openhab-persistence-jdbc-derby feature verification to fail. It is unknown to me if it is really required so I've made it an optional import for now:

[ERROR] Message: Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=openhab-persistence-jdbc-derby; type=karaf.feature; version=3.0.0.SNAPSHOT; filter:="(&(osgi.identity=openhab-persistence-jdbc-derby)(type=karaf.feature)(version>=3.0.0.SNAPSHOT))" [caused by: Unable to resolve openhab-persistence-jdbc-derby/3.0.0.SNAPSHOT: missing requirement [openhab-persistence-jdbc-derby/3.0.0.SNAPSHOT] osgi.identity; osgi.identity=org.openhab.persistence.jdbc; type=osgi.bundle; version="[3.0.0.202005240847,3.0.0.202005240847]"; resolution:=mandatory [caused by: Unable to resolve org.openhab.persistence.jdbc/3.0.0.202005240847: missing requirement [org.openhab.persistence.jdbc/3.0.0.202005240847] osgi.wiring.package; filter:="(osgi.wiring.package=javassist)"]]


The mapdb build failed because mapdb is no longer provided by openhab-core since the MapDB Storage got removed.

Related to:

@wborn wborn requested a review from cweitkamp May 24, 2020 09:09
@wborn wborn requested a review from a team as a code owner May 24, 2020 09:09
The javassist dependency previously provided by the jetty-all bundle is no longer available causing the openhab-persistence-jdbc-derby feature verification to fail.
It is unknown to me if it is really required so I've made it an optional import for now.

The mapdb build failed because mapdb is no longer provided by openhab-core since the MapDB Storage got removed.

Signed-off-by: Wouter Born <github@maindrain.net>
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp merged commit b750ae7 into openhab:master May 24, 2020
@wborn wborn deleted the fix-build branch May 24, 2020 10:38
@cpmeister cpmeister added this to the 3.0 milestone May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants