Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User name and password settings are reset when opening #1558

Closed
mueller-ma opened this issue Sep 27, 2019 · 0 comments · Fixed by #1568
Closed

User name and password settings are reset when opening #1558

mueller-ma opened this issue Sep 27, 2019 · 0 comments · Fixed by #1568
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@mueller-ma
Copy link
Member

Actual behaviour

When opening the user name or password prefs, an empty EditPrefs is shown.

Expected behaviour

When opening the user name or password prefs, the EditPrefs should be filled with the current values.

Steps to reproduce

  1. Set user name
  2. Close app
  3. Open settings
  4. The correct value is shown as summary
  5. When clicking on the pref, an empty EditPrefs is shown.

Environment data

Client

  • App version : 2.8.26-beta
@mueller-ma mueller-ma added the bug Indicates an unexpected problem or unintended behavior label Sep 27, 2019
vmadalin added a commit to vmadalin/openhab-android that referenced this issue Oct 1, 2019
@vmadalin
Fix CustomInputType issue openhab#1558
8a8d2a9
@vmadalin vmadalin mentioned this issue Oct 1, 2019
Closed
vmadalin added a commit to vmadalin/openhab-android that referenced this issue Oct 1, 2019
@vmadalin
Fix CustomInputType issue openhab#1558
30b6212 
Signed-off-by: Madalin Valceleanu <devmobile@vmadalin.com>
maniac103 added a commit to maniac103/openhab.android that referenced this issue Oct 2, 2019
@maniac103
Correctly initialize editor prefs with custom data store.
2e41cfc 
When using editor prefs with a custom data store, the initial data load
happens before assigning the data store and thus too early. Re-do the
initialization when assigning the data store to fetch the content from
the correct place.

Fixes openhab#1558

Signed-off-by: Danny Baumann <dannybaumann@web.de>
@maniac103 maniac103 mentioned this issue Oct 2, 2019
Merged
mueller-ma pushed a commit that referenced this issue Oct 2, 2019
@maniac103 @mueller-ma
Correctly initialize editor prefs with custom data store. (#1568)
82f78e7 
When using editor prefs with a custom data store, the initial data load
happens before assigning the data store and thus too early. Re-do the
initialization when assigning the data store to fetch the content from
the correct place.

Fixes #1558

Signed-off-by: Danny Baumann <dannybaumann@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly initialize editor prefs with custom data store. maniac103/openhab.android
1 participant
@mueller-ma