Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CustomInputType issue #1558 #1566

Closed
wants to merge 1 commit into from

Conversation

vmadalin
Copy link

@vmadalin vmadalin commented Oct 1, 2019

Description

#1558

Overview

By default the getDefaultSharedPreferences is used for set-up correctly the stored values like on sendDeviceInfoPrefix preference. But the problem starts when you want to work with different SharedPreferences in this case getSecretPrefs, and it's require to set it manually

untitled

Signed-off-by: Madalin Valceleanu <devmobile@vmadalin.com>
@maniac103
Copy link
Contributor

Thanks for this patch. I want to dig into this a bit more though, as it feels like a big shortcoming in the preference framework if this really is required, so @mueller-ma please hold off merging this for now.

@maniac103
Copy link
Contributor

#1568 is my take on fixing this.

@vmadalin
Copy link
Author

vmadalin commented Oct 2, 2019

@maniac103 Absolutely agree with you, the approach is quite better and more clean. So strange behaviour and thank you for report issue to google. I close this PR

@vmadalin vmadalin closed this Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants