Correctly initialize editor prefs with custom data store. #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using editor prefs with a custom data store, the initial data load happens before assigning the data store and thus too early. Re-do the initialization when assigning the data store to fetch the content from the correct place. Fixes openhab#1558 Signed-off-by: Danny Baumann <dannybaumann@web.de>
vmadalin
approved these changes
Oct 2, 2019
|
Created a bug report for that: https://issuetracker.google.com/issues/141918360 |
…e-init Signed-off-by: Danny Baumann <dannybaumann@web.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using editor prefs with a custom data store, the initial data load
happens before assigning the data store and thus too early. Re-do the
initialization when assigning the data store to fetch the content from
the correct place.
Fixes #1558