Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporary patch of pax-web-jetty to avoid slow startup times. #19

Merged
merged 1 commit into from
Jan 5, 2016

Conversation

dvanherbergen
Copy link
Contributor

Temporary solution for #10

Signed-off-by: Davy Vanherbergen davy.vanherbergen@gmail.com

@kaikreuzer
Copy link
Member

Shall we maybe place the jar somewhere on Bintray (https://bintray.com/openhab/mvn) and include it from there? Then we would not need to have it in the source repo.

@dvanherbergen
Copy link
Contributor Author

That would work too. We'll need to give it a different name then to indicate the patch.
I don't have upload rights to the openhab bintray. If you can deploy it there with a new name, I will update the PR to use that one.

@maggu2810
Copy link
Contributor

Hm, if you use another GAV for the artifact, then you have to change the feature, to use the other one.
I think for the workaround it is ok to replace the jar file.
With this PR the bundled jar is replaced and so the feature work out of the box.

Or do I miss something?

@kaikreuzer
Copy link
Member

I was rather thinking to only update the assembly descriptor to pick up the file as a Maven dependency than from the local project - this way, it should not have any impact on the features as the result is identical to the current PR.

@dvanherbergen
Copy link
Contributor Author

During the assembly we could rename it back to the original name.

@maggu2810
Copy link
Contributor

Ah okay.
If the assembly plugin support the reference using GAV then this is IMOH the cleaner solution.

@kaikreuzer
Copy link
Member

@maggu2810
Copy link
Contributor

It is up to you, but shouldn't we set the version (in the repo) to 4.2.3.sp1 or something similar to indicate it is a patched / modified 4.2.3 one?

Signed-off-by: Davy Vanherbergen <davy.vanherbergen@gmail.com>
@dvanherbergen
Copy link
Contributor Author

PR updated to use mvn dependency.

@kaikreuzer
Copy link
Member

Thanks a lot!

kaikreuzer added a commit that referenced this pull request Jan 5, 2016
Add temporary patch of pax-web-jetty to avoid slow startup times.
@kaikreuzer kaikreuzer merged commit 0c6e90c into openhab:master Jan 5, 2016
@JSurf
Copy link

JSurf commented Feb 17, 2016

Is this fix included in the current oh beta ? I tested oh2 offline distro in a raspbian jessie/java8.openjdk based docker container on a rpi2. Host OS is arch linux. Startup times are terribly slow ~ 20 minutes for first start. If yes it does not help for me

@JSurf
Copy link

JSurf commented Feb 17, 2016

Just tried with the online distro makes no difference, startup is also painfully slow no difference to the offline distro

@dvanherbergen
Copy link
Contributor Author

@JSurf, there is something else happening on your system. I just did a test with rpi1. The initial startup takes 8 minutes. Subsequent starts take about 3 minutes.
Can you try installing openHAB natively, not inside a docker container?

@JSurf
Copy link

JSurf commented Feb 26, 2016

Tested outside docker environment. Seems my issues are related to my docker container/environment.
Startup times without docker seem to be Ok

@JSurf
Copy link

JSurf commented Feb 29, 2016

Turned out that openjdk on raspbian seems to be super slow. Changed to oracle jdk provided by the rpi foundation. Now startup is very fast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants