Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blockly] don't use a shadow block for oh_runrule parameters #1260

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

ghys
Copy link
Member

@ghys ghys commented Jan 3, 2022

Reported in https://community.openhab.org/t/blockly-doesnt-like-the-value-in-key-value-pairs/131049 and other places.
This seems to be an issue with Blockly - shadow blocks with mutations don't work.

Signed-off-by: Yannick Schaus github@schaus.net

Reported in https://community.openhab.org/t/blockly-doesnt-like-the-value-in-key-value-pairs/131049 and other places.
This seems to be an issue with Blockly - shadow blocks with mutations don't work.

Signed-off-by: Yannick Schaus <github@schaus.net>
@ghys ghys requested a review from a team as a code owner January 3, 2022 16:50
@relativeci
Copy link

relativeci bot commented Jan 3, 2022

Job #318: Bundle Size — 10.67MB (~+0.01%).

22bcea0 vs a01a1ad

Changed metrics (1/8)
Metric Current Baseline
Cache Invalidation 3.76% 2.91%
Changed assets by type (1/7)
            Current     Baseline
JS 8.62MB (~+0.01%) 8.61MB

View Job #318 report on app.relative-ci.com

@ghys ghys merged commit f5c83f8 into main Jan 4, 2022
@ghys ghys added this to the 3.3 milestone Jan 4, 2022
@ghys ghys added enhancement New feature or request main ui Main UI labels Jan 4, 2022
@ghys ghys deleted the blockly-runrule-parameters branch June 22, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant