-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[habot] Add german tests and training data #1274
[habot] Add german tests and training data #1274
Conversation
Especially for the activate and deactivate object skills and various declinsion of locations. Other skills needed more training data to prevent bias by sole training data amount. Fixes openhab#1271 Signed-off-by: Jan Mattner <jan.mattner@gmail.com>
Hi, thank you very much for contributing to the HABot training, it is always appreciated 🙂 - the more the better! The DCO failure is a technicality (Commit sha: 8519ea4, Author: Jan Mattner, Committer: Jan Mattner; Expected "Jan Mattner Jan.Mattner@aitgmbh.de", but got "Jan Mattner jan.mattner@gmail.com".)... which one would you like in the final commit? However it would be great if you could solve the build error: check https://ci.openhab.org/job/PR-openHAB-WebUI/1088/console at the end, there are some format violations. |
Signed-off-by: Jan Mattner <jan.mattner@gmail.com>
fcfe9ea
to
5f4e161
Compare
Thanks @ghys. I have fixed the whitespace error, but somehow, the whole file changed, at least that's what shown in the history in GitHub, but locally in my history I just deleted the whitespaces in line 87. The spotless:check goal renders no errors locally. Now I'm lost. I haven't found a way to solve this and I cannot locally reproduce the style error from the server build. Do you have an idea what could be the problem? Some kind of different encoding or line ending issue? |
Looks like you're on Windows and you've changed the encoding to CRLF, those need to be set back to Unix-style (LF). |
Signed-off-by: Jan Mattner <jan.mattner@gmail.com>
Thanks @ghys for the hint, that seemed to be the problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Especially for the activate and deactivate object skills
and various declension of locations. Other skills needed more training
data to prevent bias by sole training data amount.
Fixes #1271
Signed-off-by: Jan Mattner jan.mattner@gmail.com