Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[habot] Add german tests and training data #1274

Merged
merged 3 commits into from
Jan 19, 2022

Conversation

JanMattner
Copy link
Contributor

Especially for the activate and deactivate object skills
and various declension of locations. Other skills needed more training
data to prevent bias by sole training data amount.
Fixes #1271

Signed-off-by: Jan Mattner jan.mattner@gmail.com

Especially for the activate and deactivate object skills
and various declinsion of locations. Other skills needed more training
data to prevent bias by sole training data amount.
Fixes openhab#1271

Signed-off-by: Jan Mattner <jan.mattner@gmail.com>
@JanMattner JanMattner requested a review from ghys as a code owner January 11, 2022 20:04
@ghys
Copy link
Member

ghys commented Jan 16, 2022

Hi, thank you very much for contributing to the HABot training, it is always appreciated 🙂 - the more the better!

The DCO failure is a technicality (Commit sha: 8519ea4, Author: Jan Mattner, Committer: Jan Mattner; Expected "Jan Mattner Jan.Mattner@aitgmbh.de", but got "Jan Mattner jan.mattner@gmail.com".)... which one would you like in the final commit?
No need to do anything on your part.

However it would be great if you could solve the build error: check https://ci.openhab.org/job/PR-openHAB-WebUI/1088/console at the end, there are some format violations.

Signed-off-by: Jan Mattner <jan.mattner@gmail.com>
@JanMattner JanMattner force-pushed the 1271-habot-improve-german-training-data branch from fcfe9ea to 5f4e161 Compare January 16, 2022 19:58
@JanMattner
Copy link
Contributor Author

Thanks @ghys.
About the DCO error: the mail in the commit message is correct (jan.mattner@gmail.com). The other one is just set in my local git config.

I have fixed the whitespace error, but somehow, the whole file changed, at least that's what shown in the history in GitHub, but locally in my history I just deleted the whitespaces in line 87. The spotless:check goal renders no errors locally.

Now I'm lost. I haven't found a way to solve this and I cannot locally reproduce the style error from the server build. Do you have an idea what could be the problem? Some kind of different encoding or line ending issue?

@ghys
Copy link
Member

ghys commented Jan 17, 2022

Looks like you're on Windows and you've changed the encoding to CRLF, those need to be set back to Unix-style (LF).
In Eclipse that would be in File > Convert Line Delimiters to > Unix (IIRC).

Signed-off-by: Jan Mattner <jan.mattner@gmail.com>
@JanMattner
Copy link
Contributor Author

Thanks @ghys for the hint, that seemed to be the problem.
I am running VS Code in Windows and as suggested in the spotless error message, I used mvn sportless:apply. Seems like in Windows, this changes all line endings by default to CRLF (I will discuss this in a separate issue).
PS: in VS Code this is easy to see and change, see https://stackoverflow.com/a/48694365

Copy link
Member

@ghys ghys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@ghys ghys merged commit 5b30761 into openhab:main Jan 19, 2022
@ghys ghys added enhancement New feature or request habot ui labels Jan 30, 2022
@ghys ghys added this to the 3.3 milestone Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request habot ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HABot] DeactivateObjectSkill does not properly recognize locations in German
2 participants