-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blockly] add help button to OH docs, provide blockly source maps for debugging #1401
Conversation
… debugging Signed-off-by: Stefan Höhn <stefan.hoehn@nfon.com>
Signed-off-by: Stefan Höhn <stefan.hoehn@nfon.com>
Co-authored-by: Yannick Schaus <github@schaus.net>
I actually wouldn't like to have the button on the end because I am sure it would be overlooked 90% of the time. That was actually my intention that people see it right away. So I'd rather leave it there. I wouldn't mind though, to change them to "Help" only (just wanted to be a bit nicer here ;-) ) - that also makes it shorter then on mobile. I have changed them all to "Help" now. |
Job #411: Bundle Size — 10.74MB (~-0.01%). |
Signed-off-by: Stefan Höhn <stefan.hoehn@nfon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright - looks good, thanks for all your valuable (and I believe important!) work on Blockly!
This is available for all openhab categories as well as in the list and color category
It will most likely lead the blockly users much quicker to the help pages as the experience in the forum shows that the help link of the context menu of an individual block is easily overlooked.
It allows much easier development of further blockly functionality as the debugger will now resolve and show the non-minified javascript code when stepping into it.
To be able to use that, source-map-loader (at least 1.1.3) should be installed via NPM.
Signed-off-by: Stefan Höhn stefan.hoehn@nfon.com
Again big thanks goes to @tweini within the blockly community.