adds poster image option to video widget #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job #509: Bundle Size — 11.06MB (0%).Changed assets by type (0/7)
|
digitaldan
force-pushed
the
poster-image
branch
from
85b8b0b
to
e2c9aec
Compare
ghys
reviewed
Aug 22, 2022
| @@ -6,7 +6,8 @@ | |||
| :stunServer="config.stunServer" | |||
| :candidatesTimeout="config.candidatesTimeout" | |||
| :startManually="config.startManually" | |||
| :hideControls="config.hideControls" /> | |||
| :hideControls="config.hideControls" | |||
| :posterURL="config.posterURL" /> | |||
There was a problem hiding this comment.
Wouldn't you need to add this to the <oh-video-videojs> alternative below too?
There was a problem hiding this comment.
🤦 Good catch, i somehow lost that in a refactor. Fixed.
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
digitaldan
force-pushed
the
poster-image
branch
from
a208f1a
to
21d8d27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Cunningham dan@digitaldan.com