Widget expressions: (Partly) Fix handling of Item name being undefined
#2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is undefined When using the `@` and `@@` shortcuts for Item displayState and state in widget expressions, properly Item name undefined. Unfortunately I did not find a way to improve that for `items[itemName]` expressions. Requesting the Item state from the server when the Item name is undefined leads to warnings in the log: ``` [WARN ] [se.internal.SseItemStatesEventBuilder] - Attempting to send a state update of an item which doesn't exist: undefined ``` Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05
force-pushed
the
widget-expression-item-undefined
branch
from
4af6f9b
to
41164ea
Compare
florian-h05
added
bug
florian-h05
changed the title
undefinedundefined
Job #1398: Bundle Size — 11MiB (~+0.01%).Warning Bundle contains 19 duplicate packages – View duplicate packages Bundle metrics
 
Bundle size by type
View job #1398 report View florian-h05:widget-expression-it... branch activity View project dashboard |
|
FYI @rkoshak IIRC you suggested to reduce the level of that message to info. I have now partially fixed the root cause. |
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
@and@@shortcuts for Item displayState and state in widget expressions, properly handle cases where the Item name isundefined.Unfortunately I did not find a way to improve that for
items[itemName]expressions.Requesting the Item state from the server when the Item name is undefined leads to warnings in the log (which might cause some confusion for the users):