Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help sidebar: Reduce list indentation #2423

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Help sidebar: Reduce list indentation #2423

merged 1 commit into from
Feb 28, 2024

Conversation

florian-h05
Copy link
Contributor

@florian-h05
Help sidebar: Reduce list indentation
658e8f2 
Fixes openhab/openhab-docs#2243.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner February 28, 2024 12:04
@florian-h05 florian-h05 mentioned this pull request Feb 28, 2024
Closed
@relativeci RelativeCI
Copy link

relativeci bot commented Feb 28, 2024

Job #1704: Bundle Size — 11.01MiB (~+0.01%).

658e8f2(current) vs 565844f main#1693(baseline)

Warning

Bundle contains 19 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
Job #1704		      Baseline
Job #1693
Regression  Initial JS 1.85MiB(~+0.01%) 1.85MiB
No change  Initial CSS 607.92KiB 607.92KiB
Change  Cache Invalidation 17.01% 16.99%
No change  Chunks 220 220
No change  Assets 242 242
Change  Modules 3089(+0.03%) 3088
No change  Duplicate Modules 164 164
No change  Duplicate Code 1.77% 1.77%
No change  Packages 150 150
No change  Duplicate Packages 18 18
Bundle size by type  Change 2 changes Regression 2 regressions
                 Current
Job #1704		      Baseline
Job #1693
Regression  JS 9.2MiB (~+0.01%) 9.2MiB
Regression  CSS 889.4KiB (~+0.01%) 889.38KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1704 report View florian-h05:sidebar-help-intenda... branch activity View project dashboard

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Feb 28, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Feb 28, 2024
@jimtng
Copy link
Contributor

jimtng commented Feb 28, 2024

Thanks! It looks much better.

@florian-h05 florian-h05 merged commit 11c6a7b into openhab:main Feb 28, 2024
6 checks passed
@florian-h05 florian-h05 deleted the sidebar-help-intendation branch February 28, 2024 12:16
@ghys
Copy link
Member

ghys commented Feb 28, 2024

When you're adding style without scoping it you might be effectively propagating it to everywhere else.

I have never trusted the scoped addition to <style> so I would suggest that you add a CSS class and change the ul style only under that class.

florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Feb 29, 2024
@florian-h05
Sidebar help: Use custom renderer instead of CSS for reduced list ite…
8e69c74 
…m indentation

Follow-up for openhab#2423.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 mentioned this pull request Feb 29, 2024
Merged
florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Feb 29, 2024
@florian-h05
Sidebar help: Use custom renderer instead of CSS for reduced list ite…
6eb8e36 
…m indentation

Follow-up for openhab#2423.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Copy link
Contributor Author

See #2430. I had to modify the marked renderer a bit so that the required styling is directly applied on the renderer output.

florian-h05 added a commit that referenced this pull request Feb 29, 2024
@florian-h05
Sidebar help: Use custom renderer instead of CSS for reduced list ind…
d6097a6 
…entation (#2430)

Follow-up for #2423.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

excessive list indentation in mainui sidebar help doc
3 participants
@florian-h05 @jimtng @ghys