-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blockly] Fix multilineedit rendering issue #2496
[blockly] Fix multilineedit rendering issue #2496
Conversation
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Job #1853: Bundle Size — 10.55MiB (~+0.01%).Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
View job #1853 report View stefan-hoehn:blockly_fix_multili... branch activity View project dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please put this to the style block of blockly-editor.vue
?
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
I just discovered an issue with the dark mode (white text on white background doesn't work very well ;-)), but this can be easily fixed: textarea.blocklyHtmlTextAreaInput
background #ffffff
color #000000 |
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Finally the long awaited fix for the dreaded blockly multilineedit rendering issue like the following
more info can be found at: google/blockly-samples#2235
The solution is to make sure that the hidden textarea style neither has a background of none or transparent.