Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blockly] Fix multilineedit rendering issue #2496

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

stefan-hoehn
Copy link
Contributor

Finally the long awaited fix for the dreaded blockly multilineedit rendering issue like the following

image

more info can be found at: google/blockly-samples#2235

The solution is to make sure that the hidden textarea style neither has a background of none or transparent.

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
@stefan-hoehn stefan-hoehn requested a review from a team as a code owner March 24, 2024 17:52
Copy link

relativeci bot commented Mar 24, 2024

Job #1853: Bundle Size — 10.55MiB (~+0.01%).

90d8fa8(current) vs 577568d main#1852(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #1853
     Baseline
Job #1852
No change  Initial JS 1.86MiB 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
Change  Cache Invalidation 18.23% 17.81%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2856 2856
No change  Duplicate Modules 141 141
No change  Duplicate Code 1.73% 1.73%
No change  Packages 94 94
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1853
     Baseline
Job #1852
Not changed  JS 8.74MiB 8.74MiB
Regression  CSS 890.03KiB (~+0.01%) 889.97KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1853 reportView stefan-hoehn:blockly_fix_multili... branch activityView project dashboard

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please put this to the style block of blockly-editor.vue?

@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Mar 24, 2024
@florian-h05 florian-h05 changed the title fix blockly multilineedit rendering issue [blockly] Fix multilineedit rendering issue Mar 24, 2024
Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
@florian-h05
Copy link
Contributor

I just discovered an issue with the dark mode (white text on white background doesn't work very well ;-)), but this can be easily fixed:

textarea.blocklyHtmlTextAreaInput
  background #ffffff
  color #000000

@stefan-hoehn
Copy link
Contributor Author

Yes, true, that one will work on dark mode as well:

image

Signed-off-by: Stefan Höhn <mail@stefanhoehn.com>
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 merged commit e5749f6 into openhab:main Mar 25, 2024
6 checks passed
@florian-h05 florian-h05 deleted the blockly_fix_multilineedit branch March 25, 2024 12:52
@florian-h05 florian-h05 added this to the 4.2 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants