Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script edit: Fix dirty handling #2508

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Script edit: Fix dirty handling #2508

merged 1 commit into from
Mar 26, 2024

Conversation

florian-h05
Copy link
Contributor

No description provided.

@florian-h05 florian-h05 requested a review from a team as a code owner March 26, 2024 11:05
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Mar 26, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone Mar 26, 2024
@florian-h05
Script edit: Fix dirty handling
bfb830d 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@relativeci RelativeCI
Copy link

relativeci bot commented Mar 26, 2024

Job #1867: Bundle Size — 10.55MiB (~+0.01%).

bfb830d(current) vs ea59ce1 main#1864(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
Job #1867		      Baseline
Job #1864
Improvement  Initial JS 1.86MiB(~-0.01%) 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
Change  Cache Invalidation 17.89% 17.64%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2856 2856
No change  Duplicate Modules 141 141
No change  Duplicate Code 1.73% 1.73%
No change  Packages 94 94
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
Job #1867		      Baseline
Job #1864
Regression  JS 8.74MiB (~+0.01%) 8.74MiB
Not changed  CSS 890.03KiB 890.03KiB
Not changed  Fonts 526.1KiB 526.1KiB
Not changed  Media 295.6KiB 295.6KiB
Not changed  IMG 140.74KiB 140.74KiB
Not changed  HTML 1.24KiB 1.24KiB
Not changed  Other 871B 871B

View job #1867 report View florian-h05:script-edit-dirty branch activity View project dashboard

@florian-h05 florian-h05 merged commit 974e28e into openhab:main Mar 26, 2024
6 checks passed
@florian-h05 florian-h05 deleted the script-edit-dirty branch March 26, 2024 11:12
florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Apr 20, 2024
@florian-h05
Script edit: Fix script creation fails due to exception
005b4b6 
Regression from openhab#2508.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 mentioned this pull request Apr 20, 2024
Merged
florian-h05 added a commit to florian-h05/openhab-webui that referenced this pull request Apr 20, 2024
@florian-h05
Script edit: Fix script creation fails due to exception
4465a45 
Regression from openhab#2508.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
florian-h05 added a commit that referenced this pull request Apr 20, 2024
@florian-h05
Script edit: Fix script creation fails due to exception (#2542)
2de1521 
Regression from #2508.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
1 participant
@florian-h05