Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup wizard: Refactor add-on selection & Add descriptions for JS Scripting & Astro #2556

Merged
merged 2 commits into from
May 1, 2024
Merged

Setup wizard: Refactor add-on selection & Add descriptions for JS Scripting & Astro #2556

merged 2 commits into from
May 1, 2024

Conversation

florian-h05
Copy link
Contributor

  • Move the selection of additional add-ons into the addons-setup-wizard.vue component.
  • Add description texts for suggested add-ons JS Scripting and Astro.

@florian-h05
Setup wizard: Refactor add-on selection
c6be792 
Move the selection of additional add-ons into the addons-setup-wizard.vue component.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05
Setup wizard: Add description texts for JS Scripting & Astro
f722619 
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
@florian-h05 florian-h05 requested a review from a team as a code owner May 1, 2024 12:52
@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels May 1, 2024
@florian-h05 florian-h05 added this to the 4.2 milestone May 1, 2024
@relativeci RelativeCI
Copy link

relativeci bot commented May 1, 2024

#1932 Bundle Size — 10.58MiB (~+0.01%).

f722619(current) vs faa4018 main#1931(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#1932		      Baseline
#1931
No change  Initial JS 1.86MiB 1.86MiB
No change  Initial CSS 607.87KiB 607.87KiB
No change  Cache Invalidation 17.78% 17.78%
No change  Chunks 222 222
No change  Assets 245 245
No change  Modules 2873 2873
No change  Duplicate Modules 146 146
No change  Duplicate Code 1.84% 1.84%
No change  Packages 95 95
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#1932		      Baseline
#1931
Regression  JS 8.77MiB (+0.01%) 8.77MiB
No change  CSS 890.63KiB 890.63KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.24KiB 1.24KiB
No change  Other 871B 871B

Bundle analysis report Branch florian-h05:wizard-addons-rfc Project dashboard

@florian-h05 florian-h05 merged commit 14a6c9e into openhab:main May 1, 2024
6 checks passed
@florian-h05 florian-h05 deleted the wizard-addons-rfc branch May 1, 2024 13:02
@florian-h05 florian-h05 mentioned this pull request May 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
1 participant
@florian-h05