-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add-on store: Add connection and country filter #2582
Conversation
#1986 Bundle Size — 10.62MiB (+0.03%).Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
Current #1986 |
Baseline #1985 |
|
---|---|---|
Initial JS | 1.86MiB (+0.02% ) |
1.86MiB |
Initial CSS | 607.87KiB |
607.87KiB |
Cache Invalidation | 17.8% |
17.72% |
Chunks | 223 |
223 |
Assets | 246 |
246 |
Modules | 2880 |
2880 |
Duplicate Modules | 149 |
149 |
Duplicate Code | 1.85% |
1.85% |
Packages | 97 |
97 |
Duplicate Packages | 2 |
2 |
Bundle size by type 1 change
1 regression
Current #1986 |
Baseline #1985 |
|
---|---|---|
JS | 8.8MiB (+0.03% ) |
8.8MiB |
CSS | 890.94KiB |
890.94KiB |
Fonts | 526.1KiB |
526.1KiB |
Media | 295.6KiB |
295.6KiB |
IMG | 140.74KiB |
140.74KiB |
HTML | 1.24KiB |
1.24KiB |
Other | 871B |
871B |
Bundle analysis report Branch mherwege:addon_filter Project dashboard
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@ghys I did some testing on a few devices and browsers, screenshots for a Galaxy S22 above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bundles/org.openhab.ui/web/src/components/addons/addon-info-table.vue
Outdated
Show resolved
Hide resolved
Just for completeness, I can think of two queries that will currently not be possible. You probably already thought about it and decided to keep it simple, because they are not common use-cases, but nevertheless:
|
I think ideally that should be something for the website, rather than in the software. It would make filtering in the software more complex. I thought about it, but decided against it.
Again, thought about it but considered add-ons that require no network access typically of limited use. LAN access would be accepted. However, this is easy enough to add and doesn't make the filtering more complex (4 instead of 3 options for the filter). So I added it. |
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@ghys @florian-h05 @jlaur Thank you all for the feedback. I incorporated it in my last commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks!
I agree that any "advanced" filtering should be implemented on the website.
Fixes openhab/openhab-core#4266. Error was introduced by #2582 and manifests itself when no country was set in the setup wizard or the locale settings. --------- Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Closes #2050
This implements filtering for connection type and country (related to region/country setting) in the addon store.
By default, it will filter for all connection types and filter out addons not supported for a specific country if info on countries is available.
Here is how this looks like on an Android mobile phone (Galaxy S22).
Filters dropdown:
Change connection type to 'No cloud allowed':
Search for 'amazon' (only one found):
Switch to 'Cloud allowed' again, search result updated to 2 add-ons:
Clear search and filter on country 'Specific for country':
Select bindings tab, only one binding shown:
Detail of binding shows connection and country detail when available:
I tried this same procedure on Chrome and Firefox (Windows), iPhone 14 (iOS 16) and iPad 9th Gen (iOS 15) and it looks OK on all these.