Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sitemap editor: Fix issues with AND, buttongrid and numeric commands #2609

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Jun 13, 2024

Fixes #2605.
Also fixes issue with Buttongrid and non-numeric commands.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner June 13, 2024 09:05
Copy link

relativeci bot commented Jun 13, 2024

#2011 Bundle Size — 10.64MiB (~+0.01%).

6828520(current) vs eb0a247 main#2007(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2011
     Baseline
#2007
No change  Initial JS 1.87MiB 1.87MiB
No change  Initial CSS 607.87KiB 607.87KiB
Change  Cache Invalidation 17.74% 17.88%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2888 2888
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.85% 1.85%
No change  Packages 97 97
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2011
     Baseline
#2007
Regression  JS 8.83MiB (~+0.01%) 8.83MiB
No change  CSS 891.48KiB 891.48KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.24KiB 1.24KiB
No change  Other 871B 871B

Bundle analysis reportBranch mherwege:sitemap_visibility_fixProject dashboard

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@florian-h05 florian-h05 changed the title sitemap builder fixes builder fixes Jun 13, 2024
@florian-h05 florian-h05 changed the title builder fixes Sitemap editor: Fix issues with AND, buttongrid and numeric commands Jun 13, 2024
@florian-h05 florian-h05 merged commit e80b221 into openhab:main Jun 13, 2024
8 checks passed
@florian-h05 florian-h05 added this to the 4.2 milestone Jun 13, 2024
@florian-h05 florian-h05 added bug Something isn't working main ui Main UI labels Jun 13, 2024
@mherwege mherwege deleted the sitemap_visibility_fix branch June 13, 2024 15:55
@lolodomo
Copy link
Contributor

@mherwege : does it cover new Button element?

@mherwege
Copy link
Contributor Author

@lolodomo No, it doesn't. And I won't be able to do that before the 4.2 release. It is a major refactoring, not just on the parser side, but mainly on the UI side. Ideally, I also don't want to be left with 2 totally different ways of defining a buttongrid in the UI, so the current approach may have to be replaced by a new approach that has the wider functionality. Of course, the old format should be parsed/converted automatically. In doing that, I actually may also need adapting the core part for this.
I started working on this, but the effort was quite big, and I have halted it for now. I will need to revisit.

This PR was just a fix to the already existing functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sitemaps with 'AND' in visibilty can not be saved after editing in code tab
3 participants