[MainUI] Expose UI command handling to native wrappers #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
#2038 Bundle Size — 10.64MiB (~+0.01%).Warning Bundle contains 2 duplicate packages – View duplicate packages Bundle metrics
|
| Current #2038 |
Baseline #2035 |
|
|---|---|---|
 Initial JS |
1.87MiB(~+0.01%) |
1.87MiB |
 Initial CSS |
607.91KiB |
607.91KiB |
 Cache Invalidation |
23.15% |
18.26% |
| Chunks |
223 |
223 |
| Assets |
246 |
246 |
| Modules |
2888 |
2888 |
| Duplicate Modules |
149 |
149 |
| Duplicate Code |
1.85% |
1.85% |
| Packages |
97 |
97 |
| Duplicate Packages |
2 |
2 |
Bundle size by type 1 change 1 regression
| Current #2038 |
Baseline #2035 |
|
|---|---|---|
| JS |
8.83MiB (~+0.01%) |
8.83MiB |
| CSS |
891.55KiB |
891.55KiB |
| Fonts |
526.1KiB |
526.1KiB |
| Media |
295.6KiB |
295.6KiB |
| IMG |
140.74KiB |
140.74KiB |
| HTML |
1.24KiB |
1.24KiB |
| Other |
871B |
871B |
Bundle analysis report Branch digitaldan:native-navigation Project dashboard
florian-h05
requested changes
Jun 24, 2024
Co-authored-by: Florian Hotze <florianh_dev@icloud.com> Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
Thank @florian-h05 , i actually now tested i didn't break anything ;-) |
florian-h05
reviewed
Jun 24, 2024
florian-h05
reviewed
Jun 24, 2024
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
yikes, i'm having a rough go with this, and with small changes to boot. |
florian-h05
approved these changes
Jun 24, 2024
florian-h05
changed the title
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the command item logic to native wrappers, like our IOS and Android clients, so they can control navigation of the app when receiving push notifications.
See openhab/openhab-android#3193