Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MainUI] Expose UI command handling to native wrappers #2622

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

digitaldan
Copy link
Contributor

This exposes the command item logic to native wrappers, like our IOS and Android clients, so they can control navigation of the app when receiving push notifications.

See openhab/openhab-android#3193

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan digitaldan requested a review from a team as a code owner June 24, 2024 02:37
Copy link

relativeci bot commented Jun 24, 2024

#2038 Bundle Size — 10.64MiB (~+0.01%).

9ed8058(current) vs e6043d4 main#2035(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2038
     Baseline
#2035
Regression  Initial JS 1.87MiB(~+0.01%) 1.87MiB
No change  Initial CSS 607.91KiB 607.91KiB
Change  Cache Invalidation 23.15% 18.26%
No change  Chunks 223 223
No change  Assets 246 246
No change  Modules 2888 2888
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.85% 1.85%
No change  Packages 97 97
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2038
     Baseline
#2035
Regression  JS 8.83MiB (~+0.01%) 8.83MiB
No change  CSS 891.55KiB 891.55KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.24KiB 1.24KiB
No change  Other 871B 871B

Bundle analysis reportBranch digitaldan:native-navigationProject dashboard

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just two minor comments:

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI labels Jun 24, 2024
digitaldan and others added 2 commits June 24, 2024 08:29
Co-authored-by: Florian Hotze <florianh_dev@icloud.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
Copy link
Contributor Author

Thank @florian-h05 , i actually now tested i didn't break anything ;-)

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine! Just one minor comment:

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
@digitaldan
Copy link
Contributor Author

yikes, i'm having a rough go with this, and with small changes to boot.

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks!

No worries wrt to the trouble, there is a reason we are four eyes and not only two 😉

@florian-h05 florian-h05 added this to the 4.2 milestone Jun 24, 2024
@florian-h05 florian-h05 merged commit 0d8c21a into openhab:main Jun 24, 2024
8 checks passed
@florian-h05 florian-h05 changed the title [MainUI] exposes navigation commands to native wrappers [MainUI] Expose UI command handling to native wrappers Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants