Remove CometVisu UI #2659
Remove CometVisu UI #2659
Conversation
Signed-off-by: Kai Kreuzer <kai@openhab.org>
|
Why do you think it is no longer maintained? Did I miss something? There is just no requirement for changes here, that's why there aren't any. This is still needed by users who are using the cometvisu with openhabs built-in webserver. It adds a backend for cometvisus built-in maintenance features. Although we recommend using the official docker container to serve the cometvisu there are still users who do not do this. So please do not remove this. |
|
Sounds as if you had missed some notifications in the past months. Please have a look at |
|
Those security advisories are not public it appears so we can't seem them. That may not be a bad thing depending on the nature of the advisories but maybe we can get a quick summary or description that doesn't reveal too many details if the advisories cannot be made fully public? In any case, if there are security problems with embedding ComitVisu with OH and there isn't going to be any fixes to those problems I agree that it should be removed despite the impact on some users. We cannot continue to distribute sofware with known security problems that will never get fixed. |
|
@rkoshak You are right, these advisories are in draft mode and thus only visible to repo maintainers so far. |
|
I haven't got any notification about those security problems, so I missed them all. |
|
I created #2671 that addresses the 4 listed security advisories (and some cleanup and minor stuff). Do I have to do anything with those security advisories, like add a comment how I tried to solve them, or anything else? |
Yes, that would be great! |
Due the fact that it is no longer maintained and newer versions of CometVisu can use openHAB's REST API directly, we can remove this UI from the repo.