Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change models to extend from opal core models. #313

Closed
2 tasks
fredkingham opened this issue Dec 4, 2017 · 4 comments
Closed
2 tasks

Change models to extend from opal core models. #313

fredkingham opened this issue Dec 4, 2017 · 4 comments
Assignees
Labels

Comments

@fredkingham
Copy link
Contributor

fredkingham commented Dec 4, 2017

In Opal we have core models such as Demographics

At the Royal Free do not seem to be using these models for example

  • where the fields are the same, or the fields at the Royal free are a superset, change to use the opal core models.
  • create and run migrations
@pacharanero
Copy link
Contributor

@davidmiller and I paired on this today and we hit issues refactoring the Allergies model to use opal.core.models.Drug, which for reasons of time has been left as a WIP in the https://github.com/openhealthcare/elcid-rfh/tree/monster-refactoring-of-antimicrobial-class branch

@pacharanero
Copy link
Contributor

We think it might be better to complete #315 first before coming back to this - there's no point refactoring models that aren't used :-)

@fredkingham
Copy link
Contributor Author

fredkingham commented Dec 12, 2017

so it turns out this really wan't easy!

So I've extended diagnosis.

What would you say to moving the Antimicrobial model into elcid and then renaming the model in opal to Drug?

Thoughts @davidmiller

If we agree, I'll close this ticket and open a new one.

I now disagree with this, I'm going to create a ticket that does what you and @pacharanero started.

Current theory, rename the Antimicrobial method in Opal to Drug. In many ways this makes more sense. In practice it might be too complicated to coordinate.

@fredkingham
Copy link
Contributor Author

closing this, we need to work out if Antimicribial == Drug, but I think this is for another time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants