Lab test cleanup 2 #772
Merged
Lab test cleanup 2 #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lready used by the lab test summary)
…rrently causing our lab tests to break. Changes the regex to account for it
…eck multiple times
fredkingham
force-pushed
the
lab-test-cleanup-2
branch
from
2a46207
to
975fec6
Compare
…s on the front end
…ns we get a string that looks like -2 - 4 so regex is the best way to cut it
…with dictionaries all the way down
…time series we may aswell only send a single value
…t observations method to make the super loop simpler
…s that can be properly tested
…bservation is pending look for the next one with a real value and use that. If there is no other value, show 'pending'
… type/date in the api
davidmiller
reviewed
Jan 3, 2020
davidmiller
reviewed
Jan 3, 2020
davidmiller
reviewed
Jan 3, 2020
elcid/api.py
Outdated
| observations = sorted( | ||
| observations, key=lambda x: x.observation_datetime | ||
| ) | ||
| observations.reverse() |
There was a problem hiding this comment.
Doesn't providing your own sorting function only to reverse it on the next line seem odd?
- ....to_timestamp() or similar ?
There was a problem hiding this comment.
So we were doing
observations = sorted(
observations, key=lambda x:- x.observation_datetime.toordinal()
)
I think this is the new way is more readable. I think I prefer this way but I'm happy with either.
There was a problem hiding this comment.
much better idea... use the reverse=True argument...
… it actually does
…t a wrapper around observation. This fixes it for long form lab tests
…were in fact never showing in tabule form. So this fixes that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this means we use the same method for both the lab test summary api end point and the results view end point.
It also fixes the bug where observations of a form such as 22.08.2019 cause the lab tests to fail