Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV32E40P fix for mem stress scenario with compressed instructions #2439

Conversation

XavierAubert
Copy link

The following code generation command would fail (see attached file for error message);

make gen_corev-dv TEST=corev_rand_illegal_instr_test CV_CORE=cv32e40p CFG=pulp_fpu_zfinx_1cyclat TEST_CFG_FILE=floating_pt_zfinx_instr_en,disable_all_trn_logs SIMULATOR=vsim SEED=1248233755

This was due to memory stress streams randomly reserving all allowed registers for compressed instructions (S0 to A5)

The fix consists in checking the number of S0:A5 registers that have been already reserved before randomization, and making sure that there are less registers taken in that range.

mem_stress_with_compress_failure.log

Copy link
Member

@MikeOpenHWGroup MikeOpenHWGroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @XavierAubert. Passes a local regression and the test invocation you provided (make gen_corev-dv TEST=corev_rand_illegal_instr_test ...) also compiles and runs under Questasim.

@MikeOpenHWGroup MikeOpenHWGroup merged commit 974da2f into openhwgroup:cv32e40p/dev May 16, 2024
1 check passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants