Feature/flush ctrl in csrwrite #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Greg pointed out: When we have an instruction in ID/EX that writes a PMP register that update gets written to the CSR the same cycle the next instruction moves from IF to ID/EX with it's PMP check done with the old value. The solution is to flush the pipeline when we get a PMP CSR write. Signed-off-by: Canberk Topal <ctopal@lowrisc.org>
Without this an instruction executed immediately after the MSECCFG write doesn't have the new MSECCFG setup applied to its execute permission.
davideschiavone
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.