Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump iOS minimum version in podspec to support Xcode 14.3 #761

Merged
merged 3 commits into from
Apr 7, 2023

Conversation

mdmathias
Copy link
Collaborator

Fixes #759

AppAuth.podspec Outdated Show resolved Hide resolved
@mdmathias mdmathias marked this pull request as ready for review April 6, 2023 22:33
Copy link

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Remember to also bump the podspec version to 1.6.1 or 1.7.0 before publishing to CocoaPods trunk. My recommendation without full context would be 1.6.1 to make it as seamless as possible for clients to get the update.

@mdmathias
Copy link
Collaborator Author

Thanks @paulb777 for the reminder. The last time we bumped a minimum OS version, we did a minor release.

de08e78

I'm inclined to stick with that precedent. Thoughts?

@paulb777
Copy link

paulb777 commented Apr 7, 2023

If the version bump affected Xcodes that are still currently be used, I would agree that it needs to be a minor version update. Since this is changing from a long ago version to a still unsupported version, I think a patch version update is better so that clients that lock to a minor version also get the fix without a respin of their podspec or Podfile.

Copy link

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the version bump is handled, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XCode 14.3 Beta cant archieve app because of AppAuth.framework pod
4 participants