Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofread Implementation Considerations #186

Merged

Conversation

selfissued
Copy link
Member

Correct issues identified while proofreading the Implementation Considerations.

Copy link
Collaborator

@Sakurann Sakurann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to hear others' opinion regarding claim-based vs claims-based. maybe I am just more used to it, but to me the former sounds more accurate.

@paulbastian
Copy link
Contributor

I would like to hear others' opinion regarding claim-based vs claims-based. maybe I am just more used to it, but to me the former sounds more accurate.

Claim-based binding has been used so far in various places and sounds more natural to me, though I'm not a native speaker.

@selfissued
Copy link
Member Author

At https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#name-claim-based-binding-of-the- , the description of the binding is:

Credentials not cryptographically bound to the identifier of the End-User possessing it (see Section 7.1), should be bound to the End-User possessing the Credential, based on the claims included in that Credential.

If it said "based on a claim included" then "claim-based" (singular) would be correct. But since it says "based on the claims included" (plural), then "claims-based" is correct. The binding is based on a set of included claims - not a single claim.

@jogu
Copy link
Contributor

jogu commented Jan 8, 2024

If it said "based on a claim included" then "claim-based" (singular) would be correct. But since it says "based on the claims included" (plural), then "claims-based" is correct. The binding is based on a set of included claims - not a single claim.

I've been puzzling for some time over why both "claim-based" and "claims-based" sounded fine to me.

I've eventually concluded that the two forms have potentially subtly different meanings because it's not necessarily clear what is meant by "claim" here.

If "claim" is referring explicitly to user attributes in the verifiable credential, then I think 'claims based' is correct as per the point @selfissued makes above.

Where the singular might be appropriate is that a single "claim" might have multiple elements - so for example, "a user that has surname 'x', first name 'y' and date of birth 'z' lives in London" is technically a singular claim). And I think an important element here is that the "surname 'x', first name 'y' and date of birth 'z'" part are not claims that the issuer of this VC is asserting about the user presenting the credential.

Reading the current text in https://openid.github.io/OpenID4VCI/openid-4-verifiable-credential-issuance-wg-draft.html#section-13.1 I think we're describing the former and hence it should be "claims based binding". However I'm not entirely sure the text there reflects the latest thinking.

@tplooker
Copy link
Contributor

tplooker commented Jan 8, 2024

If it said "based on a claim included" then "claim-based" (singular) would be correct. But since it says "based on the claims included" (plural), then "claims-based" is correct. The binding is based on a set of included claims - not a single claim.

This intuitively makes the most sense to me.

Copy link
Contributor

@awoie awoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, just one nit

openid-4-verifiable-credential-issuance-1_0.md Outdated Show resolved Hide resolved
Co-authored-by: Oliver Terbu <o.terbu@gmail.com>
@Sakurann Sakurann dismissed their stale review January 13, 2024 02:15

personally not convinced, but wont block if others think claims-based makes more sense

@Sakurann Sakurann merged commit 318d2f1 into openid:main Jan 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants