Skip to content
This repository has been archived by the owner on Jul 24, 2023. It is now read-only.

Bug: HintRetrieveResult.Builder#setHintFromProto will throw exception for valid failure responses #49

Closed
dxslly opened this issue May 9, 2017 · 1 comment
Assignees
Labels

Comments

@dxslly
Copy link
Collaborator

dxslly commented May 9, 2017

Looks like a simple fix:

private Builder setHintFromProto(@Nullable Protobufs.Hint hint) {
        mHint = (hint != null) ? Hint.fromProtobuf(hint) : null;
        return this;
}

This protobuf runtime implementation returns a default implementation for nested messages. The conditional check above needs to be modified to check against this rather than null.

@dxslly
Copy link
Collaborator Author

dxslly commented Aug 25, 2017

Fixed in 533d5c0

@dxslly dxslly closed this as completed Aug 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant