Added branding exception to the ProviderPickerActivity #94
Conversation
| // expect. To avoid confusion, a special case is made to provide the correct | ||
| // branding. Ideally this should be solved at the protocol level (e.g. optional | ||
| // metadata specified in the manifest that can override these defaults for | ||
| // trusted providers). |
There was a problem hiding this comment.
I agree that we should be able to define this from the provider manifest.
I don't really like the fact that we introduce provider-specific images and text within this repository.
I understand that you need this right now and I'm ok to merge it, but we should plan to replace it as soon as possible.
There was a problem hiding this comment.
I'm also okay with this as a temporary measure, but agree that this should be handled properly in subsequent releases.
There was a problem hiding this comment.
Agreed, this should be only be allowed temporarily for the Droidcon release. I have filed #96 to track its removal.
There was a problem hiding this comment.
If everyone is okay with this temporary fix, would you mind marking the PR as approved? Thanks!
Google's provider implementation lives inside the Google Play Services APK which has a different application label and icon than user's expect. To avoid confusion, a special case is made to provide the correct branding. Ideally this should be solved at the protocol level (e.g. optional metadata specified in the manifest that can override these defaults for trusted providers).