Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated eval calls to include "context" in response, and fixed CI #90

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

ogazitt
Copy link
Collaborator

@ogazitt ogazitt commented Apr 9, 2024

  • Added "context" to the response descriptions for the /evaluation and /evaluations calls
  • Fit the current "reason object" specification within the "context" description
  • Made the changes required to fix the CI failures for publishing the spec

Copy link

netlify bot commented Apr 9, 2024

Deploy Preview for authzen-todo canceled.

Name Link
🔨 Latest commit 5cf6c5b
🔍 Latest deploy log https://app.netlify.com/sites/authzen-todo/deploys/6615c31ba0024100082b2fcb

@baboulebou
Copy link
Collaborator

The proposed context being apparently a "free form" JSON, how would a PDP "know" what values to add in there? Are we saying this is implementation-specific, and therefore PDPs need to be parametrized somehow to reply whatever is desired?

Or is there a way to formalize this for easier interop ?

@ogazitt
Copy link
Collaborator Author

ogazitt commented Apr 11, 2024

The proposed context being apparently a "free form" JSON, how would a PDP "know" what values to add in there? Are we saying this is implementation-specific, and therefore PDPs need to be parametrized somehow to reply whatever is desired?

Or is there a way to formalize this for easier interop ?

We agreed to first add the mechanism, and then add profiles that would define specific capability negotiations.

@ogazitt ogazitt merged commit 1139587 into main Apr 11, 2024
6 checks passed
@ogazitt ogazitt deleted the api/evaluation-context branch April 11, 2024 20:16
@tulshi
Copy link
Collaborator

tulshi commented Apr 11, 2024 via email

@davidjbrossard
Copy link
Collaborator

davidjbrossard commented Apr 11, 2024 via email

@independentid
Copy link
Contributor

Having a consistent representation of the http request and headers received by the application makes it dramatically easier to write policy conditions. If the policy writer has to know what the application will give in advance, it leads to tightly coupled policy systems and applications.

IOW. Context should be defined and sent every time because the app owner doesn't know the specific policy rules are now how they will change.

This feels like an important benefit for authzen.

In IDQL with OPA we are currently sending a common request object (ReqParams)...

https://github.com/hexa-org/policy-opa/blob/main/client/hexaOpaClient/hexaOpaClientTools.go

@ogazitt ogazitt mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants