Add sentence suggesting that Issuer information should be validated by the Receiver #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulshi
approved these changes
May 24, 2024
timcappalli
requested changes
May 26, 2024
Co-authored-by: Tim Cappalli <tim@cloudauth.dev>
tulshi
approved these changes
Jun 4, 2024
timcappalli
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three problems mentioned in Issue #166:
We need to add language that suggests the Receiver validate the Issuer value before doing discovery. This PR addresses that.
We need to add TLS restriction to the stream management endpoints. PR Added language requiring authorization of stream management API #173 addresses that.
We need to restrict delivery methods to only secure options. That is already done by the fact that the Stream Configuration metadata's
delivery.methodfield can only be one ofpushorpoll.